Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Unified Diff: chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc

Issue 2453423002: Send all of the icon URLs listed in Web Manifest to WebAPK Server. (Closed)
Patch Set: Nits. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/android/webapk/webapk_update_manager.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
diff --git a/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc b/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
index eae68021667e0b8b7fce7fe43d314f6fcf78686b..194fc6366dd1cd6d8655abbcbd700de9716fbaa2 100644
--- a/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
+++ b/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
@@ -218,7 +218,7 @@ void AddToHomescreenDataFetcher::OnDidPerformInstallableCheck(
weak_observer_->OnUserTitleAvailable(shortcut_info_.user_title);
if (data.icon) {
- shortcut_info_.icon_url = data.icon_url;
+ shortcut_info_.best_icon_url = data.icon_url;
CreateLauncherIcon(*(data.icon));
return;
@@ -277,7 +277,7 @@ void AddToHomescreenDataFetcher::CreateLauncherIconFromFaviconInBackground(
bitmap_result.bitmap_data->size(), &raw_icon);
}
- shortcut_info_.icon_url = bitmap_result.icon_url;
+ shortcut_info_.best_icon_url = bitmap_result.icon_url;
CreateLauncherIconInBackground(raw_icon);
}
@@ -304,7 +304,7 @@ void AddToHomescreenDataFetcher::CreateLauncherIconInBackground(
}
if (is_generated)
- shortcut_info_.icon_url = GURL();
+ shortcut_info_.best_icon_url = GURL();
content::BrowserThread::PostTask(
content::BrowserThread::UI, FROM_HERE,
« no previous file with comments | « chrome/browser/android/webapk/webapk_update_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698