Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3948)

Unified Diff: chrome/browser/android/webapk/manifest_upgrade_detector_fetcher.h

Issue 2453423002: Send all of the icon URLs listed in Web Manifest to WebAPK Server. (Closed)
Patch Set: Nits. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/webapk/manifest_upgrade_detector_fetcher.h
diff --git a/chrome/browser/android/webapk/manifest_upgrade_detector_fetcher.h b/chrome/browser/android/webapk/manifest_upgrade_detector_fetcher.h
index 6f090a846f13bfacdfe313a69a7cb39b0f15c19d..5d3849ec69787a1ce1718546b510ed5cee415e6c 100644
--- a/chrome/browser/android/webapk/manifest_upgrade_detector_fetcher.h
+++ b/chrome/browser/android/webapk/manifest_upgrade_detector_fetcher.h
@@ -62,11 +62,11 @@ class ManifestUpgradeDetectorFetcher : public content::WebContentsObserver {
void OnDidGetInstallableData(const InstallableData& installable_data);
// Called with the computed Murmur2 hash for the app icon.
- void OnGotIconMurmur2Hash(const std::string& icon_murmur2_hash);
+ void OnGotIconMurmur2Hash(const std::string& best_icon_murmur2_hash);
void OnDataAvailable(const ShortcutInfo& info,
- const std::string& icon_murmur2_hash,
- const SkBitmap& icon);
+ const std::string& best_icon_murmur2_hash,
+ const SkBitmap& best_icon);
// Points to the Java object.
base::android::ScopedJavaGlobalRef<jobject> java_ref_;
@@ -85,7 +85,7 @@ class ManifestUpgradeDetectorFetcher : public content::WebContentsObserver {
// Downloaded data for |web_manifest_url_|.
ShortcutInfo info_;
- SkBitmap icon_;
+ SkBitmap best_icon_;
base::WeakPtrFactory<ManifestUpgradeDetectorFetcher> weak_ptr_factory_;
« no previous file with comments | « chrome/browser/android/shortcut_info.cc ('k') | chrome/browser/android/webapk/manifest_upgrade_detector_fetcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698