Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: chrome/browser/android/shortcut_helper.cc

Issue 2453423002: Send all of the icon URLs listed in Web Manifest to WebAPK Server. (Closed)
Patch Set: Nits. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/shortcut_helper.cc
diff --git a/chrome/browser/android/shortcut_helper.cc b/chrome/browser/android/shortcut_helper.cc
index 50b38e420235f2826c28085b76d7e2016547f8f3..80562638017c0ac80712e8cb8134f47f707b9076 100644
--- a/chrome/browser/android/shortcut_helper.cc
+++ b/chrome/browser/android/shortcut_helper.cc
@@ -110,8 +110,8 @@ void ShortcutHelper::AddWebappWithSkBitmap(
base::android::ConvertUTF16ToJavaString(env, info.name);
ScopedJavaLocalRef<jstring> java_short_name =
base::android::ConvertUTF16ToJavaString(env, info.short_name);
- ScopedJavaLocalRef<jstring> java_icon_url =
- base::android::ConvertUTF8ToJavaString(env, info.icon_url.spec());
+ ScopedJavaLocalRef<jstring> java_best_icon_url =
+ base::android::ConvertUTF8ToJavaString(env, info.best_icon_url.spec());
ScopedJavaLocalRef<jobject> java_bitmap;
if (icon_bitmap.getSize())
java_bitmap = gfx::ConvertToJavaBitmap(&icon_bitmap);
@@ -125,7 +125,7 @@ void ShortcutHelper::AddWebappWithSkBitmap(
Java_ShortcutHelper_addWebapp(env, java_webapp_id, java_url, java_scope_url,
java_user_title, java_name, java_short_name,
- java_icon_url, java_bitmap, info.display,
+ java_best_icon_url, java_bitmap, info.display,
info.orientation, info.source, info.theme_color,
info.background_color, callback_pointer);
}
« no previous file with comments | « chrome/browser/android/banners/app_banner_manager_android.cc ('k') | chrome/browser/android/shortcut_info.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698