Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3378)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorFetcherTest.java

Issue 2453423002: Send all of the icon URLs listed in Web Manifest to WebAPK Server. (Closed)
Patch Set: Nits. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorFetcherTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorFetcherTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorFetcherTest.java
index a302ad90e3e4ff2f9a3f6f7d32a31d3f02e024a4..48d84ab8710d18d8a768823db3b03bd888cfb7a2 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorFetcherTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorFetcherTest.java
@@ -5,7 +5,6 @@
package org.chromium.chrome.browser.webapps;
import android.content.Context;
-import android.graphics.Bitmap;
import android.test.suitebuilder.annotation.MediumTest;
import org.chromium.base.ThreadUtils;
@@ -13,6 +12,7 @@ import org.chromium.base.test.util.CallbackHelper;
import org.chromium.base.test.util.Feature;
import org.chromium.base.test.util.RetryOnFailure;
import org.chromium.chrome.browser.tab.Tab;
+import org.chromium.chrome.browser.webapps.ManifestUpgradeDetectorFetcher.FetchedManifestData;
import org.chromium.chrome.test.ChromeTabbedActivityTestBase;
import org.chromium.chrome.test.util.browser.WebappTestPage;
import org.chromium.net.test.EmbeddedTestServer;
@@ -52,12 +52,10 @@ public class ManifestUpgradeDetectorFetcherTest extends ChromeTabbedActivityTest
private String mIconMurmur2Hash;
@Override
- public void onGotManifestData(String startUrl, String scopeUrl, String name,
- String shortName, String iconUrl, String iconMurmur2Hash, Bitmap iconBitmap,
- int displayMode, int orientation, long themeColor, long backgroundColor) {
+ public void onGotManifestData(FetchedManifestData fetchedData) {
assertNull(mName);
- mName = name;
- mIconMurmur2Hash = iconMurmur2Hash;
+ mName = fetchedData.name;
+ mIconMurmur2Hash = fetchedData.bestIconMurmur2Hash;
notifyCalled();
}

Powered by Google App Engine
This is Rietveld 408576698