Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorTest.java

Issue 2453423002: Send all of the icon URLs listed in Web Manifest to WebAPK Server. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorTest.java
index 04ae09313e394e69a78de3707e9d91216e9e756c..8395fd7e223a6d6518a608931649f750dd9bf943 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorTest.java
@@ -17,6 +17,8 @@ import org.chromium.chrome.test.util.browser.WebappTestPage;
import org.chromium.content_public.common.ScreenOrientationValues;
import org.chromium.net.test.EmbeddedTestServer;
+import java.util.HashSet;
+
/**
* Tests ManifestUpgradeDetector. This class contains tests which cannot be done as JUnit tests.
*/
@@ -75,12 +77,14 @@ public class ManifestUpgradeDetectorTest extends ChromeTabbedActivityTestBase {
metaData.scope = server.getURL(WEBAPK_SCOPE_URL);
metaData.name = WEBAPK_NAME;
metaData.shortName = WEBAPK_SHORT_NAME;
- metaData.iconUrl = server.getURL(WEBAPK_ICON_URL);
+ metaData.bestIconUrl = server.getURL(WEBAPK_ICON_URL);
metaData.iconMurmur2Hash = WEBAPK_ICON_MURMUR2_HASH;
metaData.displayMode = WEBAPK_DISPLAY_MODE;
metaData.orientation = WEBAPK_ORIENTATION;
metaData.themeColor = WEBAPK_THEME_COLOR;
metaData.backgroundColor = WEBAPK_BACKGROUND_COLOR;
+ metaData.iconUrls = new HashSet<String>();
+ metaData.iconUrls.add(metaData.bestIconUrl);
return metaData;
}

Powered by Google App Engine
This is Rietveld 408576698