Send all of the icon URLs listed in Web Manifest to WebAPK Server.

chrome/browser/android/shortcut_info.h

Index: chrome/browser/android/shortcut_info.h
diff --git a/chrome/browser/android/shortcut_info.h b/chrome/browser/android/shortcut_info.h
index 85716d6a88c8a0bad823f97dd1504c4f81e94b80..5091e00ed3d684b657a2ab73617b857ef4bc2ecb 100644
--- a/chrome/browser/android/shortcut_info.h
+++ b/chrome/browser/android/shortcut_info.h
@@ -7,6 +7,8 @@
 
 #include <stdint.h>
 
+#include <vector>
+
 #include "base/strings/string16.h"
 #include "content/public/common/manifest.h"
 #include "third_party/WebKit/public/platform/modules/screen_orientation/WebScreenOrientationLockType.h"
@@ -51,7 +53,8 @@ struct ShortcutInfo {
   Source source;
   int64_t theme_color;
   int64_t background_color;
-  GURL icon_url;
+  GURL best_icon_url;
+  std::vector<GURL> icon_urls;

[dominickn, 2016/11/17 02:34:38]

Why is this a vector but it's a set in Java?

Also, I'm not a big fan of the "best" terminology. I'll think about it
overnight... 

Also, is there any need for this to be a container of GURLs? It looks like
everything that accesses this member calls spec() on each object (or starts with
a string and has to call GURL()). Why not have a container of strings?

[Xi Han, 2016/11/17 18:09:58]

In c++, we only need to get these URLs; while in Java, we need to compare them
with the ones backed in WebAPK's metadata to see whether they changed or not.

 
All right.
 
It looks like every variable which is called ".._url" is declared as GURL in
c++, I think it's better to keep this conventions.

[dominickn, 2016/11/17 18:50:53]

You've actually broken this convention in manifest_upgrade_detector_fetcher.cc,
with std::vector<std::string> icon_urls. ;)

There are plenty of cases where we have some url member which isn't a GURL type
and I think this makes sense as one of them. It will save extra string <-> GURL
type conversions in webapk_update_manager, webapk_installer, and
manifest_upgrade_detector_fetcher so it's definitely worth having.

[Xi Han, 2016/11/17 20:42:38]

Done.

 };
 
 #endif  // CHROME_BROWSER_ANDROID_SHORTCUT_INFO_H_