chrome/browser/android/webapk/webapk_installer_unittest.cc - Issue 2453423002: Send all of the icon URLs listed in Web Manifest to WebAPK Server.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/webapk/webapk_installer_unittest.cc

Issue 2453423002: Send all of the icon URLs listed in Web Manifest to WebAPK Server. (Closed)

Patch Set: pkotwicz@'s comments. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/webapk/webapk_installer_unittest.cc

diff --git a/chrome/browser/android/webapk/webapk_installer_unittest.cc b/chrome/browser/android/webapk/webapk_installer_unittest.cc

index f6a3e5d1c3c38a3773ec6b62ba385fd754cc2902..80043cb2cdae7232884d6c01c52a04ee1f0d14ca 100644

--- a/chrome/browser/android/webapk/webapk_installer_unittest.cc

+++ b/chrome/browser/android/webapk/webapk_installer_unittest.cc

@@ -129,7 +129,7 @@ class WebApkInstallerRunner {

WebApkInstaller* CreateWebApkInstaller() {

ShortcutInfo info(GURL::EmptyGURL());

- info.icon_url = icon_url_;

+ info.best_icon_url = icon_url_;

// WebApkInstaller owns itself.

WebApkInstaller* installer = new TestWebApkInstaller(info, SkBitmap());