Send all of the icon URLs listed in Web Manifest to WebAPK Server.

chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateManager.java

Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateManager.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateManager.java
index e1f967c538f5aad50bb636073ed8e02e6f384e44..27cd8e15e0222cc790368ac16ee4bfd36fbea925 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateManager.java
@@ -18,6 +18,7 @@ import org.chromium.chrome.browser.ChromeSwitches;
 import org.chromium.chrome.browser.tab.Tab;
 import org.chromium.webapk.lib.client.WebApkVersion;
 
+import java.util.Set;
 import java.util.concurrent.TimeUnit;
 
 /**
@@ -127,9 +128,9 @@ public class WebApkUpdateManager implements ManifestUpgradeDetector.Callback {
         recordUpdate(storage, false);
 
         if (data != null) {
-            updateAsync(data.startUrl, data.scopeUrl, data.name, data.shortName, data.iconUrl,
-                    data.iconMurmur2Hash, data.icon, data.displayMode, data.orientation,
-                    data.themeColor, data.backgroundColor);
+            updateAsync(data.startUrl, data.scopeUrl, data.name, data.shortName, data.bestIconUrl,
+                    data.bestIconMurmur2Hash, data.bestIcon, data.iconUrls, data.displayMode,
+                    data.orientation, data.themeColor, data.backgroundColor);
             return;
         }
 
@@ -149,8 +150,10 @@ public class WebApkUpdateManager implements ManifestUpgradeDetector.Callback {
      * Android Manifest.
      */
     private void updateAsyncUsingAndroidManifestMetaData() {
+        // If the Web Manifest isn't available anymore, it is impossible to know which is the best
+        // icon URL. In this case, pass an empty URL to indicate that there isn't any best icon URL.

[pkotwicz, 2016/11/14 22:43:11]

Nits:
- "to indicate" -> "to tell the server" (I think that my version is more
descriptive)
- "any best icon URL" -> "a best icon URL"

[Xi Han, 2016/11/15 20:07:07]

Done.

         updateAsync(mMetaData.startUrl, mMetaData.scope, mMetaData.name, mMetaData.shortName,
-                mMetaData.iconUrl, mMetaData.iconMurmur2Hash, mIcon, mMetaData.displayMode,
+                "", "", mIcon, mMetaData.iconUrlAndMurmur2HashMap.keySet(), mMetaData.displayMode,
                 mMetaData.orientation, mMetaData.themeColor, mMetaData.backgroundColor);
     }
 
@@ -158,12 +161,13 @@ public class WebApkUpdateManager implements ManifestUpgradeDetector.Callback {
      * Sends request to WebAPK Server to update WebAPK.
      */
     protected void updateAsync(String startUrl, String scopeUrl, String name, String shortName,
-            String iconUrl, String iconMurmur2Hash, Bitmap icon, int displayMode, int orientation,
-            long themeColor, long backgroundColor) {
+            String bestIconUrl, String bestIconMurmur2Hash, Bitmap bestIcon, Set<String> iconUrls,
+            int displayMode, int orientation, long themeColor, long backgroundColor) {
         int versionCode = readVersionCodeFromAndroidManifest(mWebApkPackageName);
-        nativeUpdateAsync(mId, startUrl, scopeUrl, name, shortName, iconUrl, iconMurmur2Hash, icon,
-                displayMode, orientation, themeColor, backgroundColor, mMetaData.manifestUrl,
-                mWebApkPackageName, versionCode);
+        nativeUpdateAsync(mId, startUrl, scopeUrl, name, shortName, bestIconUrl,
+                bestIconMurmur2Hash, bestIcon, iconUrls.toArray(new String[0]), displayMode,
+                orientation, themeColor, backgroundColor, mMetaData.manifestUrl, mWebApkPackageName,
+                versionCode);
     }
 
     /**
@@ -288,7 +292,7 @@ public class WebApkUpdateManager implements ManifestUpgradeDetector.Callback {
     }
 
     private static native void nativeUpdateAsync(String id, String startUrl, String scope,
-            String name, String shortName, String iconUrl, String iconMurmur2Hash, Bitmap icon,
-            int displayMode, int orientation, long themeColor, long backgroundColor,
-            String manifestUrl, String webApkPackage, int webApkVersion);
+            String name, String shortName, String bestIconUrl, String bestIconMurmur2Hash,
+            Bitmap bestIcon, String[] iconUrls, int displayMode, int orientation, long themeColor,
+            long backgroundColor, String manifestUrl, String webApkPackage, int webApkVersion);
 }