Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(916)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorFetcherTest.java

Issue 2453423002: Send all of the icon URLs listed in Web Manifest to WebAPK Server. (Closed)
Patch Set: Remove best_icon_url and best_icon_hash from metadata, but add all icon urls and icon hashs in. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorFetcherTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorFetcherTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorFetcherTest.java
index d29fdd5b793a62fe69918bfa0ef4885737952b85..50ca0972d23c4ad4a6d6c7b8d6363473524fcdee 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorFetcherTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorFetcherTest.java
@@ -53,11 +53,12 @@ public class ManifestUpgradeDetectorFetcherTest extends ChromeTabbedActivityTest
@Override
public void onGotManifestData(String startUrl, String scopeUrl, String name,
- String shortName, String iconUrl, String iconMurmur2Hash, Bitmap iconBitmap,
- int displayMode, int orientation, long themeColor, long backgroundColor) {
+ String shortName, String bestIconUrl, String bestIconMurmur2Hash, Bitmap iconBitmap,
pkotwicz 2016/11/11 21:04:19 Nit: iconBitmap -> bestIconBitmap
Xi Han 2016/11/14 19:36:10 Done.
+ String[] iconUrls, int displayMode, int orientation, long themeColor,
+ long backgroundColor) {
assertNull(mName);
mName = name;
- mIconMurmur2Hash = iconMurmur2Hash;
+ mIconMurmur2Hash = bestIconMurmur2Hash;
notifyCalled();
}

Powered by Google App Engine
This is Rietveld 408576698