Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorFetcher.java

Issue 2453423002: Send all of the icon URLs listed in Web Manifest to WebAPK Server. (Closed)
Patch Set: Remove best_icon_url and best_icon_hash from metadata, but add all icon urls and icon hashs in. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorFetcher.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorFetcher.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorFetcher.java
index 5c80c393c9b200381a15b4247ce4da641d18560e..9e1483512d4923e90d13338769909db07c930037 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorFetcher.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorFetcher.java
@@ -22,8 +22,9 @@ public class ManifestUpgradeDetectorFetcher extends EmptyTabObserver {
*/
public interface Callback {
void onGotManifestData(String startUrl, String scopeUrl, String name, String shortName,
- String iconUrl, String iconMurmur2Hash, Bitmap iconBitmap, int displayMode,
- int orientation, long themeColor, long backgroundColor);
+ String bestIconUrl, String bestIconMurmur2Hash, Bitmap iconBitmap,
pkotwicz 2016/11/11 21:04:18 iconBitmap -> bestIconBitmap
Xi Han 2016/11/14 19:36:09 Done.
+ String[] iconUrls, int displayMode, int orientation, long themeColor,
+ long backgroundColor);
}
/**
@@ -86,10 +87,11 @@ public class ManifestUpgradeDetectorFetcher extends EmptyTabObserver {
*/
@CalledByNative
private void onDataAvailable(String startUrl, String scopeUrl, String name, String shortName,
- String iconUrl, String iconMurmur2Hash, Bitmap iconBitmap, int displayMode,
- int orientation, long themeColor, long backgroundColor) {
- mCallback.onGotManifestData(startUrl, scopeUrl, name, shortName, iconUrl, iconMurmur2Hash,
- iconBitmap, displayMode, orientation, themeColor, backgroundColor);
+ String bestIconUrl, String bestIconMurmur2Hash, Bitmap iconBitmap, String[] iconUrls,
pkotwicz 2016/11/11 21:04:18 iconBitmap -> bestIconBitmap
Xi Han 2016/11/14 19:36:09 Done.
+ int displayMode, int orientation, long themeColor, long backgroundColor) {
+ mCallback.onGotManifestData(startUrl, scopeUrl, name, shortName, bestIconUrl,
+ bestIconMurmur2Hash, iconBitmap, iconUrls, displayMode, orientation, themeColor,
+ backgroundColor);
}
private native long nativeInitialize(String scope, String webManifestUrl);

Powered by Google App Engine
This is Rietveld 408576698