Send all of the icon URLs listed in Web Manifest to WebAPK Server.

chrome/browser/android/shortcut_info.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/shortcut_info.h"
 
 ShortcutInfo::ShortcutInfo(const GURL& shortcut_url)
     : url(shortcut_url),
       display(blink::WebDisplayModeBrowser),
       orientation(blink::WebScreenOrientationLockDefault),
@@ skipping 45 matching lines @@
       orientation = manifest.orientation;
   }
 
   // Set the theme color based on the manifest value, if any.
   if (manifest.theme_color != content::Manifest::kInvalidOrMissingColor)
     theme_color = manifest.theme_color;
 
   // Set the background color based on the manifest value, if any.
   if (manifest.background_color != content::Manifest::kInvalidOrMissingColor)
     background_color = manifest.background_color;
+
+  // Set the icon urls based on the icons on the manifest, if any.

[pkotwicz, 2016/11/01 00:29:49]

Nit: "on the manifest" -> "in the manifest"

[Xi Han, 2016/11/07 16:51:43]

Done.

+  icon_urls.clear();
+  for (const auto& icon : manifest.icons)

[pkotwicz, 2016/11/01 00:29:49]

Nit: "const auto& icon" -> "const Icon& icon"

[Xi Han, 2016/11/07 16:51:43]

content::Manifest::Icon, personally I would prefer to use "auto".

[pkotwicz, 2016/11/11 21:04:18]

This is the official guideline for using auto:
https://google.github.io/styleguide/cppguide.html

In my opinion, using auto here is borderline. It isn't immediately obvious what
type content::Manifest::icons is. I initially thought that
content::Manifest::icons was of type std::vector<GURL>

[Xi Han, 2016/11/14 19:36:09]

Done.

+    icon_urls.push_back(icon.src);
 }
 
 void ShortcutInfo::UpdateSource(const Source new_source) {
   source = new_source;
 }