chrome/browser/android/shortcut_info.h - Issue 2453423002: Send all of the icon URLs listed in Web Manifest to WebAPK Server.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/android/shortcut_info.h

Issue 2453423002: Send all of the icon URLs listed in Web Manifest to WebAPK Server. (Closed)

Patch Set: pkotwicz@'s comments. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/android/webapk/shell_apk/AndroidManifest.xml ('K') | « chrome/browser/android/shortcut_helper.cc ('k') | chrome/browser/android/shortcut_info.cc » ('j') | chrome/browser/android/webapk/manifest_upgrade_detector_fetcher.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_ANDROID_SHORTCUT_INFO_H_	5 #ifndef CHROME_BROWSER_ANDROID_SHORTCUT_INFO_H_

6 #define CHROME_BROWSER_ANDROID_SHORTCUT_INFO_H_	6 #define CHROME_BROWSER_ANDROID_SHORTCUT_INFO_H_

7	7

8 #include <stdint.h>	8 #include <stdint.h>
	pkotwicz 2016/11/14 22:43:11 Nit: #include <vector> Nit: #include <vector> Xi Han 2016/11/15 20:07:08 Done. Show quoted text On 2016/11/14 22:43:11, pkotwicz wrote: > Nit: #include <vector> Done.
9	9

10 #include "base/strings/string16.h"	10 #include "base/strings/string16.h"

11 #include "content/public/common/manifest.h"	11 #include "content/public/common/manifest.h"

12 #include "third_party/WebKit/public/platform/modules/screen_orientation/WebScree nOrientationLockType.h"	12 #include "third_party/WebKit/public/platform/modules/screen_orientation/WebScree nOrientationLockType.h"

13 #include "url/gurl.h"	13 #include "url/gurl.h"

14	14

15 // Information needed to create a shortcut via ShortcutHelper.	15 // Information needed to create a shortcut via ShortcutHelper.

16 struct ShortcutInfo {	16 struct ShortcutInfo {

17	17

18 // This enum is used to back a UMA histogram, and must be treated as	18 // This enum is used to back a UMA histogram, and must be treated as

(...skipping 25 matching lines...) Expand all Loading...
44 GURL url;	44 GURL url;

45 GURL scope;	45 GURL scope;

46 base::string16 user_title;	46 base::string16 user_title;

47 base::string16 name;	47 base::string16 name;

48 base::string16 short_name;	48 base::string16 short_name;

49 blink::WebDisplayMode display;	49 blink::WebDisplayMode display;

50 blink::WebScreenOrientationLockType orientation;	50 blink::WebScreenOrientationLockType orientation;

51 Source source;	51 Source source;

52 int64_t theme_color;	52 int64_t theme_color;

53 int64_t background_color;	53 int64_t background_color;

54 GURL icon_url;	54 GURL best_icon_url;

	55 std::vector<GURL> icon_urls;

55 };	56 };

56	57

57 #endif // CHROME_BROWSER_ANDROID_SHORTCUT_INFO_H_	58 #endif // CHROME_BROWSER_ANDROID_SHORTCUT_INFO_H_

OLD	NEW