Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Side by Side Diff: chrome/android/webapk/shell_apk/AndroidManifest.xml

Issue 2453423002: Send all of the icon URLs listed in Web Manifest to WebAPK Server. (Closed)
Patch Set: pkotwicz@'s comments. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- Copyright 2015 The Chromium Authors. All rights reserved. 2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.
3 Use of this source code is governed by a BSD-style license that can be 3 Use of this source code is governed by a BSD-style license that can be
4 found in the LICENSE file. 4 found in the LICENSE file.
5 --> 5 -->
6 <manifest xmlns:android="http://schemas.android.com/apk/res/android" 6 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
7 xmlns:tools="http://schemas.android.com/tools" 7 xmlns:tools="http://schemas.android.com/tools"
8 package="{{ manifest_package }}" 8 package="{{ manifest_package }}"
9 android:versionCode="{{ version_code }}" 9 android:versionCode="{{ version_code }}"
10 android:versionName="{{ version_name }}" > 10 android:versionName="{{ version_name }}" >
(...skipping 30 matching lines...) Expand all
41 <meta-data android:name="org.chromium.webapk.shell_apk.runtimeHost" andr oid:value="{{ runtime_host }}" /> 41 <meta-data android:name="org.chromium.webapk.shell_apk.runtimeHost" andr oid:value="{{ runtime_host }}" />
42 <meta-data android:name="org.chromium.webapk.shell_apk.startUrl" android :value="{{ start_url }}" /> 42 <meta-data android:name="org.chromium.webapk.shell_apk.startUrl" android :value="{{ start_url }}" />
43 <meta-data android:name="org.chromium.webapk.shell_apk.name" android:val ue="{{ name }}" /> 43 <meta-data android:name="org.chromium.webapk.shell_apk.name" android:val ue="{{ name }}" />
44 <meta-data android:name="org.chromium.webapk.shell_apk.shortName" androi d:value="{{ short_name }}" /> 44 <meta-data android:name="org.chromium.webapk.shell_apk.shortName" androi d:value="{{ short_name }}" />
45 <meta-data android:name="org.chromium.webapk.shell_apk.scope" android:va lue="{{ scope_url }}" /> 45 <meta-data android:name="org.chromium.webapk.shell_apk.scope" android:va lue="{{ scope_url }}" />
46 <meta-data android:name="org.chromium.webapk.shell_apk.displayMode" andr oid:value="{{ display_mode }}" /> 46 <meta-data android:name="org.chromium.webapk.shell_apk.displayMode" andr oid:value="{{ display_mode }}" />
47 <meta-data android:name="org.chromium.webapk.shell_apk.orientation" andr oid:value="{{ orientation }}" /> 47 <meta-data android:name="org.chromium.webapk.shell_apk.orientation" andr oid:value="{{ orientation }}" />
48 <meta-data android:name="org.chromium.webapk.shell_apk.themeColor" andro id:value="{{ theme_color }}" /> 48 <meta-data android:name="org.chromium.webapk.shell_apk.themeColor" andro id:value="{{ theme_color }}" />
49 <meta-data android:name="org.chromium.webapk.shell_apk.backgroundColor" android:value="{{ background_color }}" /> 49 <meta-data android:name="org.chromium.webapk.shell_apk.backgroundColor" android:value="{{ background_color }}" />
50 <meta-data android:name="org.chromium.webapk.shell_apk.iconId" android:r esource="@mipmap/app_icon" /> 50 <meta-data android:name="org.chromium.webapk.shell_apk.iconId" android:r esource="@mipmap/app_icon" />
51 <meta-data android:name="org.chromium.webapk.shell_apk.iconUrl" android: value="{{ icon_url }}" /> 51 <meta-data android:name="org.chromium.webapk.shell_apk.iconUrls" android :value="{{ icon_urls }}" />
52 <meta-data android:name="org.chromium.webapk.shell_apk.iconMurmur2Hash" android:value="{{ icon_murmur2_hash }}" /> 52 <meta-data android:name="org.chromium.webapk.shell_apk.iconHashes" andro id:value="{{ icon_hashes }}" />
pkotwicz 2016/11/14 22:43:11 Please make this match with the constant in WebApk
Xi Han 2016/11/15 20:07:08 Done.
53 <meta-data android:name="org.chromium.webapk.shell_apk.webManifestUrl" a ndroid:value="{{ web_manifest_url }}" /> 53 <meta-data android:name="org.chromium.webapk.shell_apk.webManifestUrl" a ndroid:value="{{ web_manifest_url }}" />
54 <service 54 <service
55 android:name="org.chromium.webapk.shell_apk.WebApkServiceFactory" 55 android:name="org.chromium.webapk.shell_apk.WebApkServiceFactory"
56 android:exported="true" 56 android:exported="true"
57 tools:ignore="ExportedService"> 57 tools:ignore="ExportedService">
58 <intent-filter> 58 <intent-filter>
59 <action android:name="android.intent.action.MAIN" /> 59 <action android:name="android.intent.action.MAIN" />
60 <category android:name="android.intent.category.WEBAPK_API" /> 60 <category android:name="android.intent.category.WEBAPK_API" />
61 </intent-filter> 61 </intent-filter>
62 </service> 62 </service>
(...skipping 11 matching lines...) Expand all
74 android:process=":webapk_sandboxed_process1" 74 android:process=":webapk_sandboxed_process1"
75 android:exported="true" 75 android:exported="true"
76 tools:ignore="ExportedService"/> 76 tools:ignore="ExportedService"/>
77 <service android:name="org.chromium.webapk.shell_apk.WebApkSandboxedProc essService2" 77 <service android:name="org.chromium.webapk.shell_apk.WebApkSandboxedProc essService2"
78 android:isolatedProcess="true" 78 android:isolatedProcess="true"
79 android:process=":webapk_sandboxed_process2" 79 android:process=":webapk_sandboxed_process2"
80 android:exported="true" 80 android:exported="true"
81 tools:ignore="ExportedService"/> 81 tools:ignore="ExportedService"/>
82 </application> 82 </application>
83 </manifest> 83 </manifest>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698