Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2453413002: [Telemetry] Provide convenient method to WaitForNetworkQuiescene (Closed)

Created:
4 years, 1 month ago by nednguyen
Modified:
4 years, 1 month ago
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add pydoc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M telemetry/telemetry/internal/actions/action_runner.py View 1 2 chunks +15 lines, -0 lines 0 comments Download
M telemetry/telemetry/internal/actions/action_runner_unittest.py View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
nednguyen
4 years, 1 month ago (2016-10-27 18:21:36 UTC) #2
rnephew (Reviews Here)
lgtm w/ comment. https://codereview.chromium.org/2453413002/diff/1/telemetry/telemetry/internal/actions/action_runner.py File telemetry/telemetry/internal/actions/action_runner.py (right): https://codereview.chromium.org/2453413002/diff/1/telemetry/telemetry/internal/actions/action_runner.py#newcode118 telemetry/telemetry/internal/actions/action_runner.py:118: def WaitForNetworkQuiescence(self, timeout_in_seconds=10): Everything else seems ...
4 years, 1 month ago (2016-10-27 18:31:23 UTC) #5
nednguyen
https://codereview.chromium.org/2453413002/diff/1/telemetry/telemetry/internal/actions/action_runner.py File telemetry/telemetry/internal/actions/action_runner.py (right): https://codereview.chromium.org/2453413002/diff/1/telemetry/telemetry/internal/actions/action_runner.py#newcode118 telemetry/telemetry/internal/actions/action_runner.py:118: def WaitForNetworkQuiescence(self, timeout_in_seconds=10): On 2016/10/27 18:31:23, rnephew (Reviews Here) ...
4 years, 1 month ago (2016-10-27 19:12:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2453413002/20001
4 years, 1 month ago (2016-10-27 19:13:03 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 19:35:52 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698