Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 2453403002: Rewrite css3/filters/effect-reference-delete.html (Closed)

Created:
4 years, 1 month ago by fs
Modified:
4 years, 1 month ago
Reviewers:
Stephen White
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rewrite css3/filters/effect-reference-delete.html Make sure we get a layout+paint before removing the <svg> (w/ descendant filter) so that we test a proper transition. Committed: https://crrev.com/4a1e83074ed4695c864f4ae9dee5468689b640b6 Cr-Commit-Position: refs/heads/master@{#428706}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -21 lines) Patch
M third_party/WebKit/LayoutTests/css3/filters/effect-reference-delete.html View 1 chunk +15 lines, -21 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
fs
Will not land this until checking if https://codereview.chromium.org/2453033004 has any bearing on things, but thought ...
4 years, 1 month ago (2016-10-27 17:00:13 UTC) #4
Stephen White
LGTM for whenever/ifever you want to land it
4 years, 1 month ago (2016-10-27 17:13:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2453403002/1
4 years, 1 month ago (2016-10-31 13:40:09 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-31 14:40:39 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-31 14:43:39 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4a1e83074ed4695c864f4ae9dee5468689b640b6
Cr-Commit-Position: refs/heads/master@{#428706}

Powered by Google App Engine
This is Rietveld 408576698