Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 24534002: Add share button to generate public url for dmprof visualizer. (Closed)

Created:
7 years, 2 months ago by junjianx
Modified:
7 years, 2 months ago
CC:
chromium-reviews, dmikurube+memory_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add share button to generate public url for dmprof visualizer. User now can click share button to generate a public url for current breakdown template. Url will be shown next to the share button. Also make some trivial improvements on GUI. BUG=259206 NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225308

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix review problems #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -17 lines) Patch
M tools/deep_memory_profiler/visualizer/app.py View 1 2 chunks +22 lines, -1 line 0 comments Download
M tools/deep_memory_profiler/visualizer/index.html View 1 2 chunks +43 lines, -12 lines 0 comments Download
M tools/deep_memory_profiler/visualizer/services.py View 1 chunk +12 lines, -0 lines 0 comments Download
M tools/deep_memory_profiler/visualizer/static/index.css View 1 chunk +35 lines, -4 lines 0 comments Download
M tools/deep_memory_profiler/visualizer/static/profiler.js View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
junjianx
I added share button to generate the url of current breakdown template. Also make some ...
7 years, 2 months ago (2013-09-25 08:42:26 UTC) #1
Dai Mikurube (NOT FULLTIME)
lgtm with a spelling fix. https://codereview.chromium.org/24534002/diff/1/tools/deep_memory_profiler/visualizer/index.html File tools/deep_memory_profiler/visualizer/index.html (right): https://codereview.chromium.org/24534002/diff/1/tools/deep_memory_profiler/visualizer/index.html#newcode60 tools/deep_memory_profiler/visualizer/index.html:60: <h1>Deep Memory Profiler Visulaizer</h1> ...
7 years, 2 months ago (2013-09-25 10:10:19 UTC) #2
sullivan
lgtm
7 years, 2 months ago (2013-09-25 14:10:11 UTC) #3
junjianx
On 2013/09/25 14:10:11, sullivan wrote: > lgtm Thanks for your review :)
7 years, 2 months ago (2013-09-26 01:12:09 UTC) #4
junjianx
On 2013/09/25 10:10:19, Dai Mikurube wrote: > lgtm with a spelling fix. > > https://codereview.chromium.org/24534002/diff/1/tools/deep_memory_profiler/visualizer/index.html ...
7 years, 2 months ago (2013-09-26 01:12:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/junjianx@chromium.org/24534002/6001
7 years, 2 months ago (2013-09-26 01:32:49 UTC) #6
commit-bot: I haz the power
7 years, 2 months ago (2013-09-26 03:28:36 UTC) #7
Message was sent while issue was closed.
Change committed as 225308

Powered by Google App Engine
This is Rietveld 408576698