Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1351)

Unified Diff: src/compiler/escape-analysis.cc

Issue 2453333002: MIPS64: Fix VirtualObject field offset calculation on Big-endian architectures (Closed)
Patch Set: Add DCHECK for big-endian Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/escape-analysis.cc
diff --git a/src/compiler/escape-analysis.cc b/src/compiler/escape-analysis.cc
index a190a5adc0ecb14cf0c0996765be9a16ee050990..d9962bc85b83dc7d1757cacf47ea28c9e6db6a19 100644
--- a/src/compiler/escape-analysis.cc
+++ b/src/compiler/escape-analysis.cc
@@ -1341,7 +1341,14 @@ namespace {
int OffsetForFieldAccess(Node* node) {
FieldAccess access = FieldAccessOf(node->op());
+#if V8_TARGET_LITTLE_ENDIAN
DCHECK_EQ(access.offset % kPointerSize, 0);
+#else
+ DCHECK_EQ((access.offset +
+ (1 << ElementSizeLog2Of(access.machine_type.representation()))) %
+ kPointerSize,
+ 0);
+#endif
return access.offset / kPointerSize;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698