Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 2453323002: Add pdf_unittests target. (Closed)

Created:
4 years, 1 month ago by snake
Modified:
4 years, 1 month ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add pdf_unittests target. Needs for https://codereview.chromium.org/2349753003/ Committed: https://crrev.com/0c349265b7e348208ae854da696be2f69b7d3f9f Cr-Commit-Position: refs/heads/master@{#428066}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -8 lines) Patch
M pdf/BUILD.gn View 2 chunks +18 lines, -0 lines 0 comments Download
A + pdf/chunk_stream_unittest.cc View 1 chunk +10 lines, -4 lines 0 comments Download
A + pdf/run_all_unittests.cc View 1 chunk +11 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
snake
4 years, 1 month ago (2016-10-27 11:07:53 UTC) #3
snake
> If we take smaller steps instead a bigger leap, we may have been > ...
4 years, 1 month ago (2016-10-27 12:09:01 UTC) #4
Lei Zhang
lgtm
4 years, 1 month ago (2016-10-27 16:23:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2453323002/1
4 years, 1 month ago (2016-10-27 16:24:19 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-27 17:22:11 UTC) #9
snake
On 2016/10/27 17:22:11, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) What ...
4 years, 1 month ago (2016-10-27 17:23:10 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0c349265b7e348208ae854da696be2f69b7d3f9f Cr-Commit-Position: refs/heads/master@{#428066}
4 years, 1 month ago (2016-10-27 17:31:16 UTC) #12
Lei Zhang
4 years, 1 month ago (2016-10-27 18:43:23 UTC) #13
Message was sent while issue was closed.
On 2016/10/27 17:23:10, snake wrote:
> On 2016/10/27 17:22:11, commit-bot: I haz the power wrote:
> > Committed patchset #1 (id:1)
> 
> What should I do next?
> Manually add target into all(or specific?) testing/buildbot/*.json ?

Looks like you did that. I asked Dirk on the other CL about try bot configs.

Powered by Google App Engine
This is Rietveld 408576698