Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 2453313002: [turbofan] Adapt test assumptions about OSR. (Closed)

Created:
4 years, 1 month ago by Michael Starzinger
Modified:
4 years, 1 month ago
Reviewers:
mythria
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Adapt test assumptions about OSR. The assumptions that OSR code is installed on {JSFunction} objects no longer holds with TurboFan and hence {assertOptimized} can report a different result dependeing on how OSR code is treated. This is working as intended. R=mythria@chromium.org Committed: https://crrev.com/375afe2acf32f93c6c38a4567caa42bf35aee331 Cr-Commit-Position: refs/heads/master@{#40624}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M test/mjsunit/mjsunit.status View 3 chunks +0 lines, -10 lines 0 comments Download
M test/mjsunit/regress-sync-optimized-lists.js View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Michael Starzinger
4 years, 1 month ago (2016-10-27 09:16:23 UTC) #3
mythria
lgtm.
4 years, 1 month ago (2016-10-27 13:03:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2453313002/1
4 years, 1 month ago (2016-10-27 14:05:27 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-27 14:07:09 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:15:40 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/375afe2acf32f93c6c38a4567caa42bf35aee331
Cr-Commit-Position: refs/heads/master@{#40624}

Powered by Google App Engine
This is Rietveld 408576698