Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 2453273002: Update LogDog client library to generate URLs. (Closed)

Created:
4 years, 1 month ago by dnj
Modified:
4 years, 1 month ago
Reviewers:
jbudorick
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Update LogDog client library to generate URLs. Update the LogDog client library to generate LogDog stream viewer URLs. This includes: - Capturing the LogDog Coordinator host from the enviornment via bootstrap. - Implementing full stream paths and URL generation. - Adjusting the StreamClient implementations to retain the prefix and coordinator host values. - Wrapping text/binary StreamClient file descriptors in a container to expose per-stream higher-level functionality. Tests have also been updated to assert the new functionality. TBR=nodir@chromium.org BUG=chromium:659291 TEST=unit Committed: https://github.com/luci/luci-py/commit/a32ab2fad3bda41efae1607ec66be78f48a9d0b9

Patch Set 1 #

Total comments: 10

Patch Set 2 : Forgot project, oops. Addressed nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+402 lines, -49 lines) Patch
M client/libs/logdog/bootstrap.py View 1 4 chunks +21 lines, -7 lines 0 comments Download
M client/libs/logdog/stream.py View 1 8 chunks +150 lines, -32 lines 0 comments Download
M client/libs/logdog/streamname.py View 1 2 chunks +81 lines, -0 lines 0 comments Download
M client/libs/logdog/tests/bootstrap_test.py View 4 chunks +24 lines, -2 lines 0 comments Download
M client/libs/logdog/tests/stream_test.py View 1 7 chunks +72 lines, -8 lines 0 comments Download
M client/libs/logdog/tests/streamname_test.py View 1 1 chunk +54 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
dnj
PTAL
4 years, 1 month ago (2016-10-27 06:04:55 UTC) #2
jbudorick
I'm not at all familiar with this code, so it'd probably be good to have ...
4 years, 1 month ago (2016-10-27 13:24:06 UTC) #3
dnj
https://codereview.chromium.org/2453273002/diff/1/client/libs/logdog/bootstrap.py File client/libs/logdog/bootstrap.py (right): https://codereview.chromium.org/2453273002/diff/1/client/libs/logdog/bootstrap.py#newcode79 client/libs/logdog/bootstrap.py:79: reg = reg or stream._default_registry On 2016/10/27 13:24:06, jbudorick ...
4 years, 1 month ago (2016-10-27 22:42:45 UTC) #4
jbudorick
https://codereview.chromium.org/2453273002/diff/1/client/libs/logdog/bootstrap.py File client/libs/logdog/bootstrap.py (right): https://codereview.chromium.org/2453273002/diff/1/client/libs/logdog/bootstrap.py#newcode79 client/libs/logdog/bootstrap.py:79: reg = reg or stream._default_registry On 2016/10/27 22:42:44, dnj ...
4 years, 1 month ago (2016-10-27 23:42:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2453273002/20001
4 years, 1 month ago (2016-11-02 00:24:03 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 00:26:42 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-py/commit/a32ab2fad3bda41efae1607ec66be78f48a9d0b9

Powered by Google App Engine
This is Rietveld 408576698