Produce the correct assertion failure expression in the face of inlining

Produce the correct assertion failure expression in the face of inlining

Fixes #27671

BUG=
R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/8007a98b5bb8020d598fef007ae27399b2ac5dc5

[Cutch, 2016-10-27 08:23:39]

Description was changed from

==========
Produce the correct assertion failure expression in the face of inlining

Fixes #27671

BUG=
==========

to

==========
Produce the correct assertion failure expression in the face of inlining

Fixes #27671

BUG=
==========

[Cutch, 2016-10-27 08:23:39]

johnmccutchan@google.com changed reviewers:
+ rmacnak@google.com

[siva, 2016-10-27 10:46:47]

asiva@google.com changed reviewers:
+ asiva@google.com

[siva, 2016-10-27 10:46:48]

DBC

https://codereview.chromium.org/2453263002/diff/1/runtime/lib/errors.cc
File runtime/lib/errors.cc (right):

https://codereview.chromium.org/2453263002/diff/1/runtime/lib/errors.cc#newco...
runtime/lib/errors.cc:27: bool hit_assertion_error = false;
why not add
const Class& assert_error_class = .....; 
here.

and replace IsAssertionerrorFunction calls in the code below with
hit_assertion_error = func.Owner == assert_error_class.raw();

https://codereview.chromium.org/2453263002/diff/1/tests/language/vm/regress_2...
File tests/language/vm/regress_27671_other.dart (right):

https://codereview.chromium.org/2453263002/diff/1/tests/language/vm/regress_2...
tests/language/vm/regress_27671_other.dart:4: //
extra comment line?

[Cutch, 2016-10-27 11:25:29]

https://codereview.chromium.org/2453263002/diff/1/runtime/lib/errors.cc
File runtime/lib/errors.cc (right):

https://codereview.chromium.org/2453263002/diff/1/runtime/lib/errors.cc#newco...
runtime/lib/errors.cc:27: bool hit_assertion_error = false;
On 2016/10/27 10:46:48, siva wrote:
> why not add
> const Class& assert_error_class = .....; 
> here.
> 
> and replace IsAssertionerrorFunction calls in the code below with
> hit_assertion_error = func.Owner == assert_error_class.raw();

Done.

https://codereview.chromium.org/2453263002/diff/1/tests/language/vm/regress_2...
File tests/language/vm/regress_27671_other.dart (right):

https://codereview.chromium.org/2453263002/diff/1/tests/language/vm/regress_2...
tests/language/vm/regress_27671_other.dart:4: //
On 2016/10/27 10:46:48, siva wrote:
> extra comment line?

Done.

[siva, 2016-10-27 13:47:20]

lgtm (Ryan's on vacation).

[Cutch, 2016-10-27 14:29:29]

Description was changed from

==========
Produce the correct assertion failure expression in the face of inlining

Fixes #27671

BUG=
==========

to

==========
Produce the correct assertion failure expression in the face of inlining

Fixes #27671

BUG=
R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/8007a98b5bb8020d598fef007ae27399b2ac5dc5
==========

[Cutch, 2016-10-27 14:29:30]

Committed patchset #2 (id:20001) manually as
8007a98b5bb8020d598fef007ae27399b2ac5dc5 (presubmit successful).