Gtk3 UI: Rename files in libgtkui containing gtk2 in their name

Gtk3 UI: Rename files in libgtkui containing gtk2 in their name

Also I needed to run git cl format because cpplint.py was failing.  I
reverted any ugly hunks like with g_object_get.

BUG=132847
R=erg@chromium.org,sky@chromium.org

Committed: https://crrev.com/a726ff8f85b8138c2245ec1fd5aa71aaa0a8deba
Cr-Commit-Position: refs/heads/master@{#428101}

[Tom (Use chromium acct), 2016-10-27 02:00:59]

erg & sky PTAL
erg: libgtkui (sorry)
sky: chrome/browser/ui/views/chrome_browser_main_extra_parts_views_linux.cc

[Tom (Use chromium acct), 2016-10-27 03:37:12]

The CQ bit was checked by thomasanderson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 03:37:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 04:54:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 04:54:02]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[sky, 2016-10-27 15:44:35]

chrome/browser/ui/views/chrome_browser_main_extra_parts_views_linux.cc LGTM -
are there other parts of this you wanted me to review?

[Elliot Glaysher, 2016-10-27 17:07:09]

lgtm

https://codereview.chromium.org/2453243002/diff/1/chrome/browser/ui/libgtkui/...
File chrome/browser/ui/libgtkui/skia_utils_gtk.h (right):

https://codereview.chromium.org/2453243002/diff/1/chrome/browser/ui/libgtkui/...
chrome/browser/ui/libgtkui/skia_utils_gtk.h:24: b*
::libgtkui::kSkiaToGDKMultiplier  \
please also fix up this case of cl format gone wild. as laid out, it looks like
pointers instead of multiplication.

[Tom (Use chromium acct), 2016-10-27 17:42:43]

The CQ bit was checked by thomasanderson@google.com to run a CQ dry run

[Tom (Use chromium acct), 2016-10-27 17:43:19]

On 2016/10/27 15:44:35, sky wrote:
> chrome/browser/ui/views/chrome_browser_main_extra_parts_views_linux.cc LGTM -
> are there other parts of this you wanted me to review?

no that's it :)

https://codereview.chromium.org/2453243002/diff/1/chrome/browser/ui/libgtkui/...
File chrome/browser/ui/libgtkui/skia_utils_gtk.h (right):

https://codereview.chromium.org/2453243002/diff/1/chrome/browser/ui/libgtkui/...
chrome/browser/ui/libgtkui/skia_utils_gtk.h:24: b*
::libgtkui::kSkiaToGDKMultiplier  \
On 2016/10/27 17:07:08, Elliot Glaysher wrote:
> please also fix up this case of cl format gone wild. as laid out, it looks
like
> pointers instead of multiplication.

Done.

[commit-bot: I haz the power, 2016-10-27 17:43:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 18:45:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 18:45:49]

Dry run: This issue passed the CQ dry run.

[Tom (Use chromium acct), 2016-10-27 18:53:29]

The CQ bit was checked by thomasanderson@google.com

[Tom (Use chromium acct), 2016-10-27 18:53:30]

The patchset sent to the CQ was uploaded after l-g-t-m from erg@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2453243002/#ps20001
(title: "Fix git cl format mistake")

[commit-bot: I haz the power, 2016-10-27 18:53:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 19:01:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-27 19:03:49]

Description was changed from

==========
Gtk3 UI: Rename files in libgtkui containing gtk2 in their name

Also I needed to run git cl format because cpplint.py was failing.  I
reverted any ugly hunks like with g_object_get.

BUG=132847
R=erg@chromium.org,sky@chromium.org
==========

to

==========
Gtk3 UI: Rename files in libgtkui containing gtk2 in their name

Also I needed to run git cl format because cpplint.py was failing.  I
reverted any ugly hunks like with g_object_get.

BUG=132847
R=erg@chromium.org,sky@chromium.org

Committed: https://crrev.com/a726ff8f85b8138c2245ec1fd5aa71aaa0a8deba
Cr-Commit-Position: refs/heads/master@{#428101}
==========

[commit-bot: I haz the power, 2016-10-27 19:03:50]

Patchset 2 (id:??) landed as
https://crrev.com/a726ff8f85b8138c2245ec1fd5aa71aaa0a8deba
Cr-Commit-Position: refs/heads/master@{#428101}