Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(890)

Unified Diff: content/browser/android/content_view_core_impl.h

Issue 2453213003: Have WebContentsViewAndroid own ViewAndroid (Closed)
Patch Set: SetDelegate Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/android/content_view_core_impl.h
diff --git a/content/browser/android/content_view_core_impl.h b/content/browser/android/content_view_core_impl.h
index 29dcb83f7db3ffbe2f70a2b0a3171968dd5d1300..1227da65901fdc21ff427c772d423b311929785d 100644
--- a/content/browser/android/content_view_core_impl.h
+++ b/content/browser/android/content_view_core_impl.h
@@ -54,8 +54,6 @@ class ContentViewCoreImpl : public ContentViewCore,
JNIEnv* env,
const base::android::JavaRef<jobject>& obj,
WebContents* web_contents,
- const base::android::JavaRef<jobject>& view_android_delegate,
- ui::WindowAndroid* window_android,
const base::android::JavaRef<jobject>& java_bridge_retained_object_set);
// ContentViewCore implementation.
@@ -389,7 +387,7 @@ class ContentViewCoreImpl : public ContentViewCore,
void OnShowUnhandledTapUIIfNeeded(int x_dip, int y_dip);
- ui::ViewAndroid* GetViewAndroid();
+ ui::ViewAndroid* GetViewAndroid() const;
boliu 2016/10/31 01:45:52 maybe not in this CL, but eventually should remove
Jinsuk Kim 2016/10/31 02:01:16 Acknowledged. Do you mean just 'const' or GetViewA
boliu 2016/10/31 02:05:45 whole method, things should ask WebContentsView fo
private:
class ContentViewUserData;
@@ -442,8 +440,6 @@ class ContentViewCoreImpl : public ContentViewCore,
// Select popup view
ui::ViewAndroid::ScopedAnchorView select_popup_;
- ui::ViewAndroid view_;
-
// Reference to the current WebContents used to determine how and what to
// display in the ContentViewCore.
WebContentsImpl* web_contents_;

Powered by Google App Engine
This is Rietveld 408576698