CRD Webapp changes to support Confirmation Dialog It2Me state

CRD Webapp changes to support Confirmation Dialog It2Me state

This change adds a new state to the CRD webapp.  This state
is sent to the Webapp/client to indicate that the remote user has
started the connection process but has not yet completed it.  For our
purposes, this state will signal that the local user must take action
(i.e. click Share on the confirmation dialog) and we can use it to
updated the text / UI state on the local machine.

The strings and webapp dialog are also updated to inform the user that
an action is required on their part to complete the process.

BUG=658459
Committed: https://crrev.com/46c2064c3f4af9437ed87ffdb777978d37f47366
Cr-Commit-Position: refs/heads/master@{#428790}

[joedow, 2016-10-27 19:24:38]

The CQ bit was checked by joedow@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 19:25:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 19:58:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 19:58:42]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[joedow, 2016-10-27 20:08:09]

The CQ bit was checked by joedow@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 20:08:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[joedow, 2016-10-27 20:43:55]

joedow@chromium.org changed reviewers:
+ jamiewalch@chromium.org

[joedow, 2016-10-27 20:43:56]

PTAL!

Beyond the normal CR stuff, my string changes could use extra some scrutiny and
an outside opinion.

Thanks,
Joe

[commit-bot: I haz the power, 2016-10-27 21:08:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 21:08:10]

Dry run: This issue passed the CQ dry run.

[Jamie, 2016-10-28 00:55:48]

LGTM modulo my string changes.

https://codereview.chromium.org/2453193004/diff/20001/remoting/resources/remo...
File remoting/resources/remoting_strings.grd (right):

https://codereview.chromium.org/2453193004/diff/20001/remoting/resources/remo...
remoting/resources/remoting_strings.grd:873: Once they enter the code, a dialog
box will be displayed for you to complete the process and begin the sharing
session.
I'm not sure how technical the term "dialog box" is, and I think it's simpler
not to refer to it anyway. How about "Once they enter the code, you will be
prompted to accept the connection and begin the sharing session."?

https://codereview.chromium.org/2453193004/diff/20001/remoting/resources/remo...
remoting/resources/remoting_strings.grd:876: Please select 'Share' on the
connection dialog box to complete the process.
We need to make sure that "Share" gets translated to the same string as the
corresponding button. See the DESCRIPTION_CONNECT string for an example of how
to do that with i18n-value-name-x tags.

[joedow, 2016-10-31 17:37:50]

The CQ bit was checked by joedow@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 17:38:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[joedow, 2016-10-31 17:38:35]

Thanks!

https://codereview.chromium.org/2453193004/diff/20001/remoting/resources/remo...
File remoting/resources/remoting_strings.grd (right):

https://codereview.chromium.org/2453193004/diff/20001/remoting/resources/remo...
remoting/resources/remoting_strings.grd:873: Once they enter the code, a dialog
box will be displayed for you to complete the process and begin the sharing
session.
On 2016/10/28 00:55:47, Jamie wrote:
> I'm not sure how technical the term "dialog box" is, and I think it's simpler
> not to refer to it anyway. How about "Once they enter the code, you will be
> prompted to accept the connection and begin the sharing session."?

I originally added the 'dialog box' comment to (attempt to) indicate to the user
they would need to interact with an external UI.  I'd prefer the simpler
phrasing so perhaps we go with that and see if there is any confusion (at which
point we can update the messaging as appropriate).

https://codereview.chromium.org/2453193004/diff/20001/remoting/resources/remo...
remoting/resources/remoting_strings.grd:876: Please select 'Share' on the
connection dialog box to complete the process.
On 2016/10/28 00:55:47, Jamie wrote:
> We need to make sure that "Share" gets translated to the same string as the
> corresponding button. See the DESCRIPTION_CONNECT string for an example of how
> to do that with i18n-value-name-x tags.

Done.

[Jamie, 2016-10-31 18:16:00]

lgtm

https://codereview.chromium.org/2453193004/diff/40001/remoting/webapp/crd/htm...
File remoting/webapp/crd/html/dialog_host.html (right):

https://codereview.chromium.org/2453193004/diff/40001/remoting/webapp/crd/htm...
remoting/webapp/crd/html/dialog_host.html:69:
i18n-value-name-1="SHARE_CONFIRM_DIALOG_CONFIRM" ></span>
Out of interest, why not re-use the HOME_SHARE_BUTTON string? AFAIK the strings
are identical in meaning (not just in English translation).

[joedow, 2016-10-31 18:21:36]

https://codereview.chromium.org/2453193004/diff/40001/remoting/webapp/crd/htm...
File remoting/webapp/crd/html/dialog_host.html (right):

https://codereview.chromium.org/2453193004/diff/40001/remoting/webapp/crd/htm...
remoting/webapp/crd/html/dialog_host.html:69:
i18n-value-name-1="SHARE_CONFIRM_DIALOG_CONFIRM" ></span>
On 2016/10/31 18:16:00, Jamie wrote:
> Out of interest, why not re-use the HOME_SHARE_BUTTON string? AFAIK the
strings
> are identical in meaning (not just in English translation).

This string should rely on the translation on the confirmation dialog.  If for
some reason a localizer decided to translate 'share' to 'accept' for instance,
then I'd want that text here and not the text from the webapp UI.

[commit-bot: I haz the power, 2016-10-31 18:22:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 18:22:35]

Dry run: This issue passed the CQ dry run.

[joedow, 2016-10-31 18:57:09]

The CQ bit was checked by joedow@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 18:57:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[joedow, 2016-10-31 19:01:32]

The CQ bit was checked by joedow@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 19:02:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 20:22:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 20:22:59]

Dry run: This issue passed the CQ dry run.

[joedow, 2016-10-31 20:23:42]

The CQ bit was checked by joedow@chromium.org

[joedow, 2016-10-31 20:23:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamiewalch@chromium.org
Link to the patchset: https://codereview.chromium.org/2453193004/#ps60001
(title: "Merging with upstream CL and updating the connection string enum to
match")

[commit-bot: I haz the power, 2016-10-31 20:24:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 20:30:19]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-31 20:32:21]

Description was changed from

==========
CRD Webapp changes to support Confirmation Dialog It2Me state

This change adds a new state to the CRD webapp.  This state
is sent to the Webapp/client to indicate that the remote user has
started the connection process but has not yet completed it.  For our
purposes, this state will signal that the local user must take action
(i.e. click Share on the confirmation dialog) and we can use it to
updated the text / UI state on the local machine.

The strings and webapp dialog are also updated to inform the user that
an action is required on their part to complete the process.

BUG=658459
==========

to

==========
CRD Webapp changes to support Confirmation Dialog It2Me state

This change adds a new state to the CRD webapp.  This state
is sent to the Webapp/client to indicate that the remote user has
started the connection process but has not yet completed it.  For our
purposes, this state will signal that the local user must take action
(i.e. click Share on the confirmation dialog) and we can use it to
updated the text / UI state on the local machine.

The strings and webapp dialog are also updated to inform the user that
an action is required on their part to complete the process.

BUG=658459

Committed: https://crrev.com/46c2064c3f4af9437ed87ffdb777978d37f47366
Cr-Commit-Position: refs/heads/master@{#428790}
==========

[commit-bot: I haz the power, 2016-10-31 20:32:22]

Patchset 4 (id:??) landed as
https://crrev.com/46c2064c3f4af9437ed87ffdb777978d37f47366
Cr-Commit-Position: refs/heads/master@{#428790}