Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2453163002: Take advantage of implicit std::unique_ptr<>(nulltpr_t) ctor. (Closed)

Created:
4 years, 1 month ago by Tom Sepez
Modified:
4 years, 1 month ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Take advantage of implicit std::unique_ptr<>(nulltpr_t) ctor. Committed: https://pdfium.googlesource.com/pdfium/+/e5cb0b191aed020da99757c117dae014ea65c6ba

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -21 lines) Patch
M core/fpdfapi/font/cpdf_font.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/page/cpdf_clippath.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/page/cpdf_colorspace.cpp View 4 chunks +7 lines, -7 lines 0 comments Download
M core/fpdfapi/page/fpdf_page_func.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M core/fpdfapi/render/fpdf_render_pattern.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfdoc/cpdf_annotlist.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/fpdf_progressive.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdfdoc_unittest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdfview.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_FontMap.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M xfa/fgas/crt/fgas_memory.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Tom Sepez
Lei, quick review. Turns out this case is called out in the standard for convenience.
4 years, 1 month ago (2016-10-26 21:49:47 UTC) #4
Lei Zhang
lgtm
4 years, 1 month ago (2016-10-26 22:04:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2453163002/1
4 years, 1 month ago (2016-10-26 22:05:52 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 22:06:14 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/e5cb0b191aed020da99757c117dae014ea65...

Powered by Google App Engine
This is Rietveld 408576698