Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Unified Diff: net/tools/quic/stateless_rejector.cc

Issue 2453113002: Fix object-lifetime issues in async GetProof callpaths (Closed)
Patch Set: Updated patchset dependency Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/tools/quic/stateless_rejector.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/stateless_rejector.cc
diff --git a/net/tools/quic/stateless_rejector.cc b/net/tools/quic/stateless_rejector.cc
index ab69fc9f94be2c3351dfee6064f65b4a90e04f45..aacb290f4e1586433e0d4c0db3ea0faa8ce44073 100644
--- a/net/tools/quic/stateless_rejector.cc
+++ b/net/tools/quic/stateless_rejector.cc
@@ -54,7 +54,9 @@ StatelessRejector::StatelessRejector(
clock_(clock),
random_(random),
crypto_config_(crypto_config),
- compressed_certs_cache_(compressed_certs_cache) {}
+ compressed_certs_cache_(compressed_certs_cache),
+ proof_(new QuicCryptoProof),
+ params_(new QuicCryptoNegotiatedParameters) {}
StatelessRejector::~StatelessRejector() {}
@@ -88,7 +90,7 @@ void StatelessRejector::Process(std::unique_ptr<StatelessRejector> rejector,
rejector_ptr->crypto_config_->ValidateClientHello(
rejector_ptr->chlo_, rejector_ptr->client_address_.address(),
rejector_ptr->server_address_.address(), rejector_ptr->version_,
- rejector_ptr->clock_, &rejector_ptr->proof_,
+ rejector_ptr->clock_, rejector_ptr->proof_,
std::unique_ptr<ValidateCallback>(
new ValidateCallback(std::move(rejector), std::move(done_cb))));
}
@@ -128,7 +130,7 @@ void StatelessRejector::ProcessClientHello(
/*reject_only=*/true, connection_id_, server_address_.address(),
client_address_, version_, versions_,
/*use_stateless_rejects=*/true, server_designated_connection_id_, clock_,
- random_, compressed_certs_cache_, &params_, &proof_,
+ random_, compressed_certs_cache_, params_, proof_,
QuicCryptoStream::CryptoMessageFramingOverhead(version_),
chlo_packet_size_, std::move(cb));
}
« no previous file with comments | « net/tools/quic/stateless_rejector.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698