Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1110)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/quic/test_tools/mock_crypto_client_stream.cc

Issue 2453113002: Fix object-lifetime issues in async GetProof callpaths (Closed)
Patch Set: Updated patchset dependency Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/test_tools/crypto_test_utils_test.cc ('k') | net/tools/quic/quic_dispatcher_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/test_tools/mock_crypto_client_stream.cc
diff --git a/net/quic/test_tools/mock_crypto_client_stream.cc b/net/quic/test_tools/mock_crypto_client_stream.cc
index d53f681fe78915df44b7f2d81fa3cdb4a1d5a5a9..d55dd839c6d6c67aa7280255123c12122ad7fca3 100644
--- a/net/quic/test_tools/mock_crypto_client_stream.cc
+++ b/net/quic/test_tools/mock_crypto_client_stream.cc
@@ -58,8 +58,8 @@ void MockCryptoClientStream::CryptoConnect() {
case ZERO_RTT: {
encryption_established_ = true;
handshake_confirmed_ = false;
- crypto_negotiated_params_.key_exchange = kC255;
- crypto_negotiated_params_.aead = kAESG;
+ crypto_negotiated_params_->key_exchange = kC255;
+ crypto_negotiated_params_->aead = kAESG;
if (proof_verify_details_) {
reinterpret_cast<QuicClientSessionBase*>(session())
->OnProofVerifyDetailsAvailable(*proof_verify_details_);
@@ -77,8 +77,8 @@ void MockCryptoClientStream::CryptoConnect() {
case CONFIRM_HANDSHAKE: {
encryption_established_ = true;
handshake_confirmed_ = true;
- crypto_negotiated_params_.key_exchange = kC255;
- crypto_negotiated_params_.aead = kAESG;
+ crypto_negotiated_params_->key_exchange = kC255;
+ crypto_negotiated_params_->aead = kAESG;
if (proof_verify_details_) {
reinterpret_cast<QuicClientSessionBase*>(session())
->OnProofVerifyDetailsAvailable(*proof_verify_details_);
« no previous file with comments | « net/quic/test_tools/crypto_test_utils_test.cc ('k') | net/tools/quic/quic_dispatcher_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698