Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(844)

Unified Diff: net/quic/core/crypto/quic_crypto_client_config.cc

Issue 2453113002: Fix object-lifetime issues in async GetProof callpaths (Closed)
Patch Set: Updated patchset dependency Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/core/crypto/quic_crypto_client_config.cc
diff --git a/net/quic/core/crypto/quic_crypto_client_config.cc b/net/quic/core/crypto/quic_crypto_client_config.cc
index a42e687b226574fa08050ba9e111784a2db42a4b..3df23ce756f77034dfb4452d6e53acbb1236770d 100644
--- a/net/quic/core/crypto/quic_crypto_client_config.cc
+++ b/net/quic/core/crypto/quic_crypto_client_config.cc
@@ -420,7 +420,7 @@ void QuicCryptoClientConfig::FillInchoateClientHello(
const CachedState* cached,
QuicRandom* rand,
bool demand_x509_proof,
- QuicCryptoNegotiatedParameters* out_params,
+ scoped_refptr<QuicCryptoNegotiatedParameters> out_params,
CryptoHandshakeMessage* out) const {
out->set_tag(kCHLO);
// TODO(rch): Remove this when we remove:
@@ -494,7 +494,7 @@ QuicErrorCode QuicCryptoClientConfig::FillClientHello(
QuicWallTime now,
QuicRandom* rand,
const ChannelIDKey* channel_id_key,
- QuicCryptoNegotiatedParameters* out_params,
+ scoped_refptr<QuicCryptoNegotiatedParameters> out_params,
CryptoHandshakeMessage* out,
string* error_details) const {
DCHECK(error_details != nullptr);
@@ -797,7 +797,7 @@ QuicErrorCode QuicCryptoClientConfig::ProcessRejection(
const QuicVersion version,
StringPiece chlo_hash,
CachedState* cached,
- QuicCryptoNegotiatedParameters* out_params,
+ scoped_refptr<QuicCryptoNegotiatedParameters> out_params,
string* error_details) {
DCHECK(error_details != nullptr);
@@ -840,7 +840,7 @@ QuicErrorCode QuicCryptoClientConfig::ProcessServerHello(
QuicVersion version,
const QuicVersionVector& negotiated_versions,
CachedState* cached,
- QuicCryptoNegotiatedParameters* out_params,
+ scoped_refptr<QuicCryptoNegotiatedParameters> out_params,
string* error_details) {
DCHECK(error_details != nullptr);
@@ -903,7 +903,7 @@ QuicErrorCode QuicCryptoClientConfig::ProcessServerConfigUpdate(
const QuicVersion version,
StringPiece chlo_hash,
CachedState* cached,
- QuicCryptoNegotiatedParameters* out_params,
+ scoped_refptr<QuicCryptoNegotiatedParameters> out_params,
string* error_details) {
DCHECK(error_details != nullptr);
« no previous file with comments | « net/quic/core/crypto/quic_crypto_client_config.h ('k') | net/quic/core/crypto/quic_crypto_client_config_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698