Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Unified Diff: net/quic/core/crypto/crypto_handshake.h

Issue 2453113002: Fix object-lifetime issues in async GetProof callpaths (Closed)
Patch Set: Updated patchset dependency Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/core/crypto/crypto_server_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/crypto/crypto_handshake.h
diff --git a/net/quic/core/crypto/crypto_handshake.h b/net/quic/core/crypto/crypto_handshake.h
index 017fa056f29f4b4330bc3dd05194c00576bfd193..48bee663df84e0809262c7f2d987bd1477c8102e 100644
--- a/net/quic/core/crypto/crypto_handshake.h
+++ b/net/quic/core/crypto/crypto_handshake.h
@@ -99,10 +99,10 @@ struct NET_EXPORT_PRIVATE CrypterPair {
};
// Parameters negotiated by the crypto handshake.
-struct NET_EXPORT_PRIVATE QuicCryptoNegotiatedParameters {
+struct NET_EXPORT_PRIVATE QuicCryptoNegotiatedParameters
+ : public base::RefCounted<QuicCryptoNegotiatedParameters> {
// Initializes the members to 0 or empty values.
QuicCryptoNegotiatedParameters();
- ~QuicCryptoNegotiatedParameters();
QuicTag key_exchange;
QuicTag aead;
@@ -149,6 +149,10 @@ struct NET_EXPORT_PRIVATE QuicCryptoNegotiatedParameters {
// Default to false; set to true if the client indicates that it supports sct
// by sending CSCT tag with an empty value in client hello.
bool sct_supported_by_client;
+
+ private:
+ friend class base::RefCounted<QuicCryptoNegotiatedParameters>;
+ virtual ~QuicCryptoNegotiatedParameters();
};
// QuicCryptoConfig contains common configuration between clients and servers.
« no previous file with comments | « no previous file | net/quic/core/crypto/crypto_server_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698