net/tools/quic/stateless_rejector.h - Issue 2453113002: Fix object-lifetime issues in async GetProof callpaths

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/tools/quic/stateless_rejector.h

Issue 2453113002: Fix object-lifetime issues in async GetProof callpaths (Closed)

Patch Set: Updated patchset dependency Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « net/tools/quic/quic_dispatcher_test.cc ('k') | net/tools/quic/stateless_rejector.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef NET_QUIC_STATELESS_REJECTOR_H_	5 #ifndef NET_QUIC_STATELESS_REJECTOR_H_

6 #define NET_QUIC_STATELESS_REJECTOR_H_	6 #define NET_QUIC_STATELESS_REJECTOR_H_

7	7

8 #include "base/strings/string_piece.h"	8 #include "base/strings/string_piece.h"

9 #include "net/quic/core/crypto/crypto_framer.h"	9 #include "net/quic/core/crypto/crypto_framer.h"

10 #include "net/quic/core/crypto/quic_crypto_server_config.h"	10 #include "net/quic/core/crypto/quic_crypto_server_config.h"

(...skipping 89 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
100 QuicByteCount chlo_packet_size_;	100 QuicByteCount chlo_packet_size_;

101 IPEndPoint client_address_;	101 IPEndPoint client_address_;

102 IPEndPoint server_address_;	102 IPEndPoint server_address_;

103 const QuicClock* clock_;	103 const QuicClock* clock_;

104 QuicRandom* random_;	104 QuicRandom* random_;

105 const QuicCryptoServerConfig* crypto_config_;	105 const QuicCryptoServerConfig* crypto_config_;

106 QuicCompressedCertsCache* compressed_certs_cache_;	106 QuicCompressedCertsCache* compressed_certs_cache_;

107 CryptoHandshakeMessage chlo_;	107 CryptoHandshakeMessage chlo_;

108 std::unique_ptr<CryptoHandshakeMessage> reply_;	108 std::unique_ptr<CryptoHandshakeMessage> reply_;

109 CryptoFramer crypto_framer_;	109 CryptoFramer crypto_framer_;

110 QuicCryptoProof proof_;	110 scoped_refptr<QuicCryptoProof> proof_;

111 QuicCryptoNegotiatedParameters params_;	111 scoped_refptr<QuicCryptoNegotiatedParameters> params_;

112	112

113 DISALLOW_COPY_AND_ASSIGN(StatelessRejector);	113 DISALLOW_COPY_AND_ASSIGN(StatelessRejector);

114 };	114 };

115	115

116 } // namespace net	116 } // namespace net

117	117

118 #endif // NET_QUIC_STATELESS_REJECTOR_H_	118 #endif // NET_QUIC_STATELESS_REJECTOR_H_

OLD	NEW