Fix object-lifetime issues in async GetProof callpaths

net/quic/core/quic_crypto_stream.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/quic/core/quic_crypto_stream.h"
 
 #include <string>
 
 #include "base/strings/string_piece.h"
 #include "net/quic/core/crypto/crypto_handshake.h"
 #include "net/quic/core/crypto/crypto_utils.h"
 #include "net/quic/core/quic_connection.h"
 #include "net/quic/core/quic_flags.h"
 #include "net/quic/core/quic_session.h"
 #include "net/quic/core/quic_utils.h"
 
 using std::string;
 using base::StringPiece;
 using net::SpdyPriority;
 
 namespace net {
 
 #define ENDPOINT                                                               \
   (session()->perspective() == Perspective::IS_SERVER ? "Server: " : "Client:" \
                                                                      " ")
 
 QuicCryptoStream::QuicCryptoStream(QuicSession* session)
     : ReliableQuicStream(kCryptoStreamId, session),
       encryption_established_(false),
-      handshake_confirmed_(false) {
+      handshake_confirmed_(false),
+      crypto_negotiated_params_(new QuicCryptoNegotiatedParameters) {
   crypto_framer_.set_visitor(this);
   // The crypto stream is exempt from connection level flow control.
   DisableConnectionFlowControlForThisStream();
 }
 
+QuicCryptoStream::~QuicCryptoStream() {}
+
 // static
 QuicByteCount QuicCryptoStream::CryptoMessageFramingOverhead(
     QuicVersion version) {
   return QuicPacketCreator::StreamFramePacketOverhead(
       version, PACKET_8BYTE_CONNECTION_ID,
       /*include_version=*/true,
       /*include_path_id=*/true,
       /*include_diversification_nonce=*/true, PACKET_1BYTE_PACKET_NUMBER,
       /*offset=*/0);
 }
@@ skipping 45 matching lines @@
 bool QuicCryptoStream::ExportKeyingMaterial(StringPiece label,
                                             StringPiece context,
                                             size_t result_len,
                                             string* result) const {
   if (!handshake_confirmed()) {
     DLOG(ERROR) << "ExportKeyingMaterial was called before forward-secure"
                 << "encryption was established.";
     return false;
   }
   return CryptoUtils::ExportKeyingMaterial(
-      crypto_negotiated_params_.subkey_secret, label, context, result_len,
+      crypto_negotiated_params_->subkey_secret, label, context, result_len,
       result);
 }
 
 bool QuicCryptoStream::ExportTokenBindingKeyingMaterial(string* result) const {
   if (!encryption_established()) {
     QUIC_BUG << "ExportTokenBindingKeyingMaterial was called before initial"
              << "encryption was established.";
     return false;
   }
   return CryptoUtils::ExportKeyingMaterial(
-      crypto_negotiated_params_.initial_subkey_secret, "EXPORTER-Token-Binding",
+      crypto_negotiated_params_->initial_subkey_secret,
+      "EXPORTER-Token-Binding",
       /* context= */ "", 32, result);
 }
 
 const QuicCryptoNegotiatedParameters&
 QuicCryptoStream::crypto_negotiated_params() const {
-  return crypto_negotiated_params_;
+  return *crypto_negotiated_params_;
 }
 
 }  // namespace net