Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Side by Side Diff: net/quic/core/quic_crypto_server_stream.h

Issue 2453113002: Fix object-lifetime issues in async GetProof callpaths (Closed)
Patch Set: Updated patchset dependency Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/quic/core/quic_crypto_client_stream.cc ('k') | net/quic/core/quic_crypto_server_stream.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_QUIC_QUIC_CRYPTO_SERVER_STREAM_H_ 5 #ifndef NET_QUIC_QUIC_CRYPTO_SERVER_STREAM_H_
6 #define NET_QUIC_QUIC_CRYPTO_SERVER_STREAM_H_ 6 #define NET_QUIC_QUIC_CRYPTO_SERVER_STREAM_H_
7 7
8 #include <cstdint> 8 #include <cstdint>
9 #include <memory> 9 #include <memory>
10 #include <string> 10 #include <string>
(...skipping 193 matching lines...) Expand 10 before | Expand all | Expand 10 after
204 204
205 // crypto_config_ contains crypto parameters for the handshake. 205 // crypto_config_ contains crypto parameters for the handshake.
206 const QuicCryptoServerConfig* crypto_config_; 206 const QuicCryptoServerConfig* crypto_config_;
207 207
208 // compressed_certs_cache_ contains a set of most recently compressed certs. 208 // compressed_certs_cache_ contains a set of most recently compressed certs.
209 // Owned by QuicDispatcher. 209 // Owned by QuicDispatcher.
210 QuicCompressedCertsCache* compressed_certs_cache_; 210 QuicCompressedCertsCache* compressed_certs_cache_;
211 211
212 // Server's certificate chain and signature of the server config, as provided 212 // Server's certificate chain and signature of the server config, as provided
213 // by ProofSource::GetProof. 213 // by ProofSource::GetProof.
214 QuicCryptoProof crypto_proof_; 214 scoped_refptr<QuicCryptoProof> crypto_proof_;
215 215
216 // Hash of the last received CHLO message which can be used for generating 216 // Hash of the last received CHLO message which can be used for generating
217 // server config update messages. 217 // server config update messages.
218 std::string chlo_hash_; 218 std::string chlo_hash_;
219 219
220 // Pointer to the active callback that will receive the result of 220 // Pointer to the active callback that will receive the result of
221 // the client hello validation request and forward it to 221 // the client hello validation request and forward it to
222 // FinishProcessingHandshakeMessage for processing. nullptr if no 222 // FinishProcessingHandshakeMessage for processing. nullptr if no
223 // handshake message is being validated. 223 // handshake message is being validated.
224 ValidateCallback* validate_client_hello_cb_; 224 ValidateCallback* validate_client_hello_cb_;
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
258 258
259 // Set to true, once the server has received information from the 259 // Set to true, once the server has received information from the
260 // client that it supports stateless reject. 260 // client that it supports stateless reject.
261 // TODO(jokulik): Remove once client stateless reject support 261 // TODO(jokulik): Remove once client stateless reject support
262 // becomes the default. 262 // becomes the default.
263 bool peer_supports_stateless_rejects_; 263 bool peer_supports_stateless_rejects_;
264 264
265 // Size of the packet containing the most recently received CHLO. 265 // Size of the packet containing the most recently received CHLO.
266 QuicByteCount chlo_packet_size_; 266 QuicByteCount chlo_packet_size_;
267 267
268 // Pointer to the active callback which will receive the results of
269 // ProcessClientHello and forward it to
270 // FinishProcessingHandshakeMessageAfterProcessClientHello.
271 ProcessClientHelloCallback* process_client_hello_cb_;
272
268 DISALLOW_COPY_AND_ASSIGN(QuicCryptoServerStream); 273 DISALLOW_COPY_AND_ASSIGN(QuicCryptoServerStream);
269 }; 274 };
270 275
271 } // namespace net 276 } // namespace net
272 277
273 #endif // NET_QUIC_QUIC_CRYPTO_SERVER_STREAM_H_ 278 #endif // NET_QUIC_QUIC_CRYPTO_SERVER_STREAM_H_
OLDNEW
« no previous file with comments | « net/quic/core/quic_crypto_client_stream.cc ('k') | net/quic/core/quic_crypto_server_stream.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698