Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2453103002: Fix the build after r427784. (Closed)

Created:
4 years, 1 month ago by Lei Zhang
Modified:
4 years, 1 month ago
Reviewers:
hongchan
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the build after r427784. r427784 originally landed as r427752, but failed with an error. Earlier, r427683 landed, adding the same #include. Rather than conflicting, the CQ somehow ignored this. Thus when r427752 got reverted as r427772, the #include got deleted, and the build failed. TBR=hongchan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/fdb97e6b7a2cd5fc44f93a167c88bda2ccac3a3c Cr-Commit-Position: refs/heads/master@{#427785}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M pdf/pdfium/pdfium_engine.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Lei Zhang
TBR
4 years, 1 month ago (2016-10-26 20:50:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2453103002/1
4 years, 1 month ago (2016-10-26 20:51:55 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-26 20:52:54 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 20:55:19 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fdb97e6b7a2cd5fc44f93a167c88bda2ccac3a3c
Cr-Commit-Position: refs/heads/master@{#427785}

Powered by Google App Engine
This is Rietveld 408576698