Create FieldTrialAllocator.Size histogram

Create FieldTrialAllocator.Size histogram

Create a histogram that tracks field trial allocator memory usage for
Chrome subprocesses.

BUG=659781
Committed: https://crrev.com/49276387106ee08c45a49c40bc2157f42838342e
Cr-Commit-Position: refs/heads/master@{#428029}

[lawrencewu, 2016-10-26 20:50:29]

lawrencewu@chromium.org changed reviewers:
+ asvitkine@chromium.org

[lawrencewu, 2016-10-26 20:50:30]

initial review

[Alexei Svitkine (slow), 2016-10-26 20:53:20]

https://codereview.chromium.org/2453093002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/2453093002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:66293: -    units="bytes">
You added these in an earlier CL - and you're removing them because we never end
up logging them? Is that the case?

https://codereview.chromium.org/2453093002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2453093002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:66241: +<histogram
name="UMA.Metrics.FieldTrialAllocator.Size" units="bytes">
UNA.Metrics. is redundant - just UMA. is fine.

[lawrencewu, 2016-10-26 21:04:22]

s/UMA.Metrics/UMA

https://codereview.chromium.org/2453093002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/2453093002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:66293: -    units="bytes">
On 2016/10/26 20:53:20, Alexei Svitkine (slow) wrote:
> You added these in an earlier CL - and you're removing them because we never
end
> up logging them? Is that the case?

Yes, that is the case.

https://codereview.chromium.org/2453093002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2453093002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:66241: +<histogram
name="UMA.Metrics.FieldTrialAllocator.Size" units="bytes">
On 2016/10/26 20:53:20, Alexei Svitkine (slow) wrote:
> UNA.Metrics. is redundant - just UMA. is fine.

Done.

[Alexei Svitkine (slow), 2016-10-26 21:14:59]

lgtm

[lawrencewu, 2016-10-27 13:58:38]

The CQ bit was checked by lawrencewu@chromium.org

[lawrencewu, 2016-10-27 13:58:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
asvitkine@chromium.org
Link to the patchset: https://codereview.chromium.org/2453093002/#ps40001
(title: "forgot to remove todos")

[commit-bot: I haz the power, 2016-10-27 13:59:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 15:07:29]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-27 15:09:51]

Description was changed from

==========
Create FieldTrialAllocator.Size histogram

Create a histogram that tracks field trial allocator memory usage for
Chrome subprocesses.

BUG=659781
==========

to

==========
Create FieldTrialAllocator.Size histogram

Create a histogram that tracks field trial allocator memory usage for
Chrome subprocesses.

BUG=659781

Committed: https://crrev.com/49276387106ee08c45a49c40bc2157f42838342e
Cr-Commit-Position: refs/heads/master@{#428029}
==========

[commit-bot: I haz the power, 2016-10-27 15:09:52]

Patchset 3 (id:??) landed as
https://crrev.com/49276387106ee08c45a49c40bc2157f42838342e
Cr-Commit-Position: refs/heads/master@{#428029}