Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2453083002: Revert of Call status before reset in gclient sync. (Closed)

Created:
4 years, 1 month ago by justincohen
Modified:
4 years, 1 month ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert of Call status before reset in gclient sync. (patchset #2 id:20001 of https://codereview.chromium.org/2447813003/ ) Reason for revert: https://codereview.chromium.org/2444403003/ makes this pretty redundant. Reverting this. Original issue's description: > Call status before reset in gclient sync. > > Calling status before reset will ensure files that have no been changed do not > get deleted by reset --hard. > > BUG=642711 > > Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/d74a7b4c14512d95cb46204bb7a70ba5666b5eb7 TBR=sdefresne@chromium.org,maruel@chromium.org,dpranke@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=642711 Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/b655dbda883a2668433a54166ff1f42cddd13c8e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M gclient_scm.py View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
justincohen
Created Revert of Call status before reset in gclient sync.
4 years, 1 month ago (2016-10-26 20:38:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2453083002/1
4 years, 1 month ago (2016-10-26 20:38:59 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 1 month ago (2016-10-26 20:39:02 UTC) #5
justincohen
dpranke@ ptal revert.
4 years, 1 month ago (2016-10-26 20:39:35 UTC) #6
Dirk Pranke
lgtm
4 years, 1 month ago (2016-10-26 21:34:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2453083002/1
4 years, 1 month ago (2016-10-26 21:34:54 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/depot_tools/+/b655dbda883a2668433a54166ff1f42cddd13c8e
4 years, 1 month ago (2016-10-26 21:35:01 UTC) #12
sdefresne
4 years, 1 month ago (2016-10-26 21:53:35 UTC) #13
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698