Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 2453053002: Revert of Fix sandbox::PolicyBase leak (Closed)

Created:
4 years, 1 month ago by pastarmovj
Modified:
4 years, 1 month ago
CC:
chromium-reviews, jam, pennymac+watch_chromium.org, darin-cc_chromium.org, rickyz+watch_chromium.org, wfh+watch_chromium.org, cpu_(ooo_6.6-7.5)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix sandbox::PolicyBase leak (patchset #4 id:60001 of https://codereview.chromium.org/2316333003/ ) Reason for revert: The change breaks Chrome on RDP like WIndows Terminal Services Published Apps or Citrix ZenApp. Original issue's description: > Fix sandbox::PolicyBase leak > > StartSandboxedProcess was missing a Release call, so this was always > leaking. Use scoped_refptr instead to fix that and prevent it from > happening in the future. > TBR=piman@chromium.org > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng > > Committed: https://crrev.com/b6a4ff86c730756a73d63cc882ef818fb7818a53 > Cr-Commit-Position: refs/heads/master@{#417313} TBR=wfh@chromium.org,cpu@chromium.org,jbauman@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -41 lines) Patch
M content/common/sandbox_init_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/sandbox_win.cc View 6 chunks +7 lines, -8 lines 0 comments Download
M sandbox/win/sandbox_poc/main_ui_window.cc View 2 chunks +2 lines, -1 line 0 comments Download
M sandbox/win/src/broker_services.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sandbox/win/src/broker_services.cc View 7 chunks +9 lines, -11 lines 0 comments Download
M sandbox/win/src/policy_target_test.cc View 10 chunks +12 lines, -12 lines 0 comments Download
M sandbox/win/src/sandbox.h View 3 chunks +2 lines, -3 lines 0 comments Download
M sandbox/win/tests/common/controller.h View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/win/tests/common/controller.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
pastarmovj
Created Revert of Fix sandbox::PolicyBase leak
4 years, 1 month ago (2016-10-26 18:23:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2453053002/1
4 years, 1 month ago (2016-10-26 18:24:42 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/94326) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 1 month ago (2016-10-26 18:28:37 UTC) #5
pastarmovj
4 years, 1 month ago (2016-10-26 18:31:34 UTC) #6
automatic revert fails (as expected but it was worth trying) commencing to a
manual revert.

Powered by Google App Engine
This is Rietveld 408576698