Drop an obsolete TODO in profile_signin_confirmation_dialog.cc

Drop an obsolete TODO in profile_signin_confirmation_dialog.cc

The TODO is almost 4 years old, and suggests a change in behaviour which does
not even seem to have a bug assigned. The TODO's informational value is
questionnable at this point, and the code apparently serves its purpose without
the TODO being implemented.

Therefore this CL drops the TODO.

Referencing bug 171236, because the TODO was added in https://codereview.chromium.org/12221111, which is associated with that bug.

BUG=171236, 543839
Committed: https://crrev.com/bf24b814282916263de44c16bda2fa2344bc9957
Cr-Commit-Position: refs/heads/master@{#429579}

[vabr (Chromium), 2016-10-28 11:17:25]

Description was changed from

==========
Drop an obsolete TODO in profile_signin_confirmation_dialog.cc

The TODO is almost 4 years old, and suggests a change in behaviour which does
not even seem to have a bug assigned. The TODO's informational value is
questionnable at this point, and the code apparently serves its purpose without
the TODO being implemented.

Therefore this CL drops the TODO.

BUG=171236,543839
==========

to

==========
Drop an obsolete TODO in profile_signin_confirmation_dialog.cc

The TODO is almost 4 years old, and suggests a change in behaviour which does
not even seem to have a bug assigned. The TODO's informational value is
questionnable at this point, and the code apparently serves its purpose without
the TODO being implemented.

Therefore this CL drops the TODO.

Referencing bug 171236, because the TODO was added in
https://codereview.chromium.org/12221111, which is associated with that bug.

BUG=171236,543839
==========

[vabr (Chromium), 2016-10-28 11:17:59]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[vabr (Chromium), 2016-10-28 11:18:17]

vabr@chromium.org changed reviewers:
+ rogerta@chromium.org

[vabr (Chromium), 2016-10-28 11:18:17]

Hi Roger,

Could you please review?

Thanks!
Vaclav

[commit-bot: I haz the power, 2016-10-28 11:18:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 12:07:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 12:07:45]

Dry run: This issue passed the CQ dry run.

[vabr (Chromium), 2016-10-28 13:00:58]

vabr@chromium.org changed reviewers:
+ rogerta@chromium.org

[vabr (Chromium), 2016-10-28 13:00:58]

(Last time I forgot to add the reviewer.)

Hi Roger,

Could you please review?

Thanks!
Vaclav

[vabr (Chromium), 2016-11-02 10:47:19]

Hi Roger,

A friendly ping about this review! :)

Cheers,
Vaclav

[Roger Tawa OOO till Jul 10th, 2016-11-02 17:34:05]

lgtm

Sorry for delay.

[vabr (Chromium), 2016-11-03 07:31:54]

On 2016/11/02 17:34:05, Roger Tawa wrote:
> lgtm
> 
> Sorry for delay.

No worries. Thank you!

[vabr (Chromium), 2016-11-03 07:32:00]

The CQ bit was checked by vabr@chromium.org

[commit-bot: I haz the power, 2016-11-03 07:32:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 08:02:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 08:02:58]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[vabr (Chromium), 2016-11-03 08:19:37]

The CQ bit was checked by vabr@chromium.org

[commit-bot: I haz the power, 2016-11-03 08:19:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 09:32:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 09:32:54]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[vabr (Chromium), 2016-11-03 14:35:54]

The CQ bit was checked by vabr@chromium.org

[commit-bot: I haz the power, 2016-11-03 14:36:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 14:43:20]

Description was changed from

==========
Drop an obsolete TODO in profile_signin_confirmation_dialog.cc

The TODO is almost 4 years old, and suggests a change in behaviour which does
not even seem to have a bug assigned. The TODO's informational value is
questionnable at this point, and the code apparently serves its purpose without
the TODO being implemented.

Therefore this CL drops the TODO.

Referencing bug 171236, because the TODO was added in
https://codereview.chromium.org/12221111, which is associated with that bug.

BUG=171236,543839
==========

to

==========
Drop an obsolete TODO in profile_signin_confirmation_dialog.cc

The TODO is almost 4 years old, and suggests a change in behaviour which does
not even seem to have a bug assigned. The TODO's informational value is
questionnable at this point, and the code apparently serves its purpose without
the TODO being implemented.

Therefore this CL drops the TODO.

Referencing bug 171236, because the TODO was added in
https://codereview.chromium.org/12221111, which is associated with that bug.

BUG=171236,543839
==========

[commit-bot: I haz the power, 2016-11-03 14:43:20]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-03 14:47:27]

Description was changed from

==========
Drop an obsolete TODO in profile_signin_confirmation_dialog.cc

The TODO is almost 4 years old, and suggests a change in behaviour which does
not even seem to have a bug assigned. The TODO's informational value is
questionnable at this point, and the code apparently serves its purpose without
the TODO being implemented.

Therefore this CL drops the TODO.

Referencing bug 171236, because the TODO was added in
https://codereview.chromium.org/12221111, which is associated with that bug.

BUG=171236,543839
==========

to

==========
Drop an obsolete TODO in profile_signin_confirmation_dialog.cc

The TODO is almost 4 years old, and suggests a change in behaviour which does
not even seem to have a bug assigned. The TODO's informational value is
questionnable at this point, and the code apparently serves its purpose without
the TODO being implemented.

Therefore this CL drops the TODO.

Referencing bug 171236, because the TODO was added in
https://codereview.chromium.org/12221111, which is associated with that bug.

BUG=171236,543839

Committed: https://crrev.com/bf24b814282916263de44c16bda2fa2344bc9957
Cr-Commit-Position: refs/heads/master@{#429579}
==========

[commit-bot: I haz the power, 2016-11-03 14:47:28]

Patchset 1 (id:??) landed as
https://crrev.com/bf24b814282916263de44c16bda2fa2344bc9957
Cr-Commit-Position: refs/heads/master@{#429579}