Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 2453033002: Revert of [ObjC ARC] Converts ios/chrome/app to ARC. (Closed)

Created:
4 years, 1 month ago by mohsen
Modified:
4 years, 1 month ago
CC:
chromium-reviews, mac-reviews_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [ObjC ARC] Converts ios/chrome/app to ARC. (patchset #1 id:1 of https://codereview.chromium.org/2449063002/ ) Reason for revert: Compile failure on ios-device builder: https://uberchromegw.corp.google.com/i/chromium.mac/builders/ios-device/builds/26773 Original issue's description: > [ObjC ARC] Converts ios/chrome/app to ARC. > > Notable changes:none. > > BUG=659150 > TEST=None. > > Committed: https://crrev.com/7a1f218b33faf5d0dd637f6a6854566e6cd80a3d > Cr-Commit-Position: refs/heads/master@{#427722} TBR=eugenebut@chromium.org,thestig@chromium.org,stkhapugin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=659150 Committed: https://crrev.com/c729d2352ac75ddef20681351074810de122c559 Cr-Commit-Position: refs/heads/master@{#427729}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -18 lines) Patch
M ios/chrome/app/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M ios/chrome/app/application_delegate/memory_warning_helper.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M ios/chrome/app/deferred_initialization_runner.mm View 4 chunks +6 lines, -8 lines 0 comments Download
M ios/chrome/app/safe_mode_crashing_modules_config.mm View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
mohsen
Created Revert of [ObjC ARC] Converts ios/chrome/app to ARC.
4 years, 1 month ago (2016-10-26 17:23:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2453033002/1
4 years, 1 month ago (2016-10-26 17:23:35 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-26 17:25:44 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 17:50:50 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c729d2352ac75ddef20681351074810de122c559
Cr-Commit-Position: refs/heads/master@{#427729}

Powered by Google App Engine
This is Rietveld 408576698