Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2453013004:
Fix use-after-scope bug in IntrusiveHeapTest.HeapIndex. (Closed)
DescriptionFix use-after-scope bug in IntrusiveHeapTest.HeapIndex.
The heap object contains references to the handles, and its destructor must run before they go out of scope.
This is caught with -fsanitize=address -fsanitize-address-use-after-scope. See https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/251354/steps/blink_platform_unittests%20%28with%20patch%29%20on%20Ubuntu-12.04/logs/stdio
BUG=649897
Committed: https://crrev.com/7e7cb2767b4aa6811b8c202d8cce97ab020c4174
Cr-Commit-Position: refs/heads/master@{#428152}
Patch Set 1 #
Messages
Total messages: 19 (12 generated)
The CQ bit was checked by krasin@chromium.org to run a CQ dry run
Description was changed from ========== Fix use-after-scope bug in IntrusiveHeapTest.HeapIndex. The heap object contains references to the elements, and its destructor must run before the go out of scope. This is caught with -fsanitize=address -fsanitize-address-use-after-scope. BUG=649897 ========== to ========== Fix use-after-scope bug in IntrusiveHeapTest.HeapIndex. The heap object contains references to the elements, and its destructor must run before they go out of scope. This is caught with -fsanitize=address -fsanitize-address-use-after-scope. BUG=649897 ==========
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
krasin@chromium.org changed reviewers: + rmcilroy@chromium.org
Description was changed from ========== Fix use-after-scope bug in IntrusiveHeapTest.HeapIndex. The heap object contains references to the elements, and its destructor must run before they go out of scope. This is caught with -fsanitize=address -fsanitize-address-use-after-scope. BUG=649897 ========== to ========== Fix use-after-scope bug in IntrusiveHeapTest.HeapIndex. The heap object contains references to the elements, and its destructor must run before they go out of scope. This is caught with -fsanitize=address -fsanitize-address-use-after-scope. See https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium... BUG=649897 ==========
Description was changed from ========== Fix use-after-scope bug in IntrusiveHeapTest.HeapIndex. The heap object contains references to the elements, and its destructor must run before they go out of scope. This is caught with -fsanitize=address -fsanitize-address-use-after-scope. See https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium... BUG=649897 ========== to ========== Fix use-after-scope bug in IntrusiveHeapTest.HeapIndex. The heap object contains references to the handles, and its destructor must run before they go out of scope. This is caught with -fsanitize=address -fsanitize-address-use-after-scope. See https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium... BUG=649897 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
rmcilroy@chromium.org changed reviewers: + alexclarke@chromium.org
Looks fine to me but I don't know this code - adding Alex to approve.
The CQ bit was checked by alexclarke@chromium.org
lgtm
On 2016/10/27 21:58:15, alex clarke wrote: > lgtm Thank you, Ross and Alex!
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix use-after-scope bug in IntrusiveHeapTest.HeapIndex. The heap object contains references to the handles, and its destructor must run before they go out of scope. This is caught with -fsanitize=address -fsanitize-address-use-after-scope. See https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium... BUG=649897 ========== to ========== Fix use-after-scope bug in IntrusiveHeapTest.HeapIndex. The heap object contains references to the handles, and its destructor must run before they go out of scope. This is caught with -fsanitize=address -fsanitize-address-use-after-scope. See https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium... BUG=649897 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Fix use-after-scope bug in IntrusiveHeapTest.HeapIndex. The heap object contains references to the handles, and its destructor must run before they go out of scope. This is caught with -fsanitize=address -fsanitize-address-use-after-scope. See https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium... BUG=649897 ========== to ========== Fix use-after-scope bug in IntrusiveHeapTest.HeapIndex. The heap object contains references to the handles, and its destructor must run before they go out of scope. This is caught with -fsanitize=address -fsanitize-address-use-after-scope. See https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium... BUG=649897 Committed: https://crrev.com/7e7cb2767b4aa6811b8c202d8cce97ab020c4174 Cr-Commit-Position: refs/heads/master@{#428152} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/7e7cb2767b4aa6811b8c202d8cce97ab020c4174 Cr-Commit-Position: refs/heads/master@{#428152} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
