Mus: Remove dependency on ServerWindowCompositorFrameSink from FrameGenerator

Mus: Remove dependency on ServerWindowCompositorFrameSink from FrameGenerator

FrameGenerator will live in mus-ws but ServerWindowCompositorFrameSink
will live in mus-gpu. Thus, we should not access it directly.

ServerWindowCompositorFrameSinkManager now serves as a cache of state
from CompositorFrames submitted to mus-gpu. FrameGenerator looks up
that state in ServerWindowCompositorFrameSink.

BUG=658988
Committed: https://crrev.com/fadcdb0baa1441b4f0ddf1e80e456079b926a357
Cr-Commit-Position: refs/heads/master@{#428182}

[Fady Samuel, 2016-10-26 16:14:34]

fsamuel@chromium.org changed reviewers:
+ sadrul@chromium.org

[Fady Samuel, 2016-10-26 18:45:39]

PTAL Sadrul. I got rid of may_contain_video in FrameGenerator.

[Fady Samuel, 2016-10-27 04:36:24]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 04:36:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 04:39:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 04:39:03]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[sadrul, 2016-10-27 05:06:30]

Some nits. lgtm

https://codereview.chromium.org/2453013002/diff/20001/services/ui/ws/frame_ge...
File services/ui/ws/frame_generator.cc (right):

https://codereview.chromium.org/2453013002/diff/20001/services/ui/ws/frame_ge...
services/ui/ws/frame_generator.cc:249: window->AddObserver(this);
Need to merge this with the crash fix.

https://codereview.chromium.org/2453013002/diff/20001/services/ui/ws/server_w...
File services/ui/ws/server_window_compositor_frame_sink_manager.h (right):

https://codereview.chromium.org/2453013002/diff/20001/services/ui/ws/server_w...
services/ui/ws/server_window_compositor_frame_sink_manager.h:65: void
SetLastSurfaceId(mojom::CompositorFrameSinkType type,
Since this also sets the size, how about SetLatestSurfaceInfo()?

https://codereview.chromium.org/2453013002/diff/20001/services/ui/ws/server_w...
services/ui/ws/server_window_compositor_frame_sink_manager.h:67: const
gfx::Size& frame_size);
nit: s/Last/Latest/ in these?

[Fady Samuel, 2016-10-27 05:46:36]

fsamuel@chromium.org changed reviewers:
+ sky@chromium.org

[Fady Samuel, 2016-10-27 05:46:37]

PTAL sky@!

https://codereview.chromium.org/2453013002/diff/20001/services/ui/ws/frame_ge...
File services/ui/ws/frame_generator.cc (right):

https://codereview.chromium.org/2453013002/diff/20001/services/ui/ws/frame_ge...
services/ui/ws/frame_generator.cc:249: window->AddObserver(this);
On 2016/10/27 05:06:30, sadrul wrote:
> Need to merge this with the crash fix.

Will do once it lands.

https://codereview.chromium.org/2453013002/diff/20001/services/ui/ws/server_w...
File services/ui/ws/server_window_compositor_frame_sink_manager.h (right):

https://codereview.chromium.org/2453013002/diff/20001/services/ui/ws/server_w...
services/ui/ws/server_window_compositor_frame_sink_manager.h:65: void
SetLastSurfaceId(mojom::CompositorFrameSinkType type,
On 2016/10/27 05:06:30, sadrul wrote:
> Since this also sets the size, how about SetLatestSurfaceInfo()?

Done.

https://codereview.chromium.org/2453013002/diff/20001/services/ui/ws/server_w...
services/ui/ws/server_window_compositor_frame_sink_manager.h:67: const
gfx::Size& frame_size);
On 2016/10/27 05:06:30, sadrul wrote:
> nit: s/Last/Latest/ in these?

Done.

[Fady Samuel, 2016-10-27 05:46:53]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 05:47:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 07:48:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 07:48:24]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sky, 2016-10-27 15:58:01]

LGTM

https://codereview.chromium.org/2453013002/diff/40001/services/ui/ws/server_w...
File services/ui/ws/server_window_compositor_frame_sink_manager.h (right):

https://codereview.chromium.org/2453013002/diff/40001/services/ui/ws/server_w...
services/ui/ws/server_window_compositor_frame_sink_manager.h:27:
CompositorFrameSinkData(CompositorFrameSinkData&& other);
explicit

[Fady Samuel, 2016-10-27 20:52:05]

Fixed broken test. CQ'ing now.

https://codereview.chromium.org/2453013002/diff/40001/services/ui/ws/server_w...
File services/ui/ws/server_window_compositor_frame_sink_manager.h (right):

https://codereview.chromium.org/2453013002/diff/40001/services/ui/ws/server_w...
services/ui/ws/server_window_compositor_frame_sink_manager.h:27:
CompositorFrameSinkData(CompositorFrameSinkData&& other);
On 2016/10/27 15:58:01, sky wrote:
> explicit

I don't think I can do that. STL assumes the move constructor is implicit.

[Fady Samuel, 2016-10-27 20:52:11]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2016-10-27 20:52:11]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2453013002/#ps60001
(title: "Fix unit tests")

[commit-bot: I haz the power, 2016-10-27 20:52:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 20:57:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 20:57:48]

Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Fady Samuel, 2016-10-27 21:47:19]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2016-10-27 21:47:19]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2453013002/#ps80001
(title: "Rebased")

[commit-bot: I haz the power, 2016-10-27 21:48:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 22:57:16]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-10-27 23:01:07]

Description was changed from

==========
Mus: Remove dependency on ServerWindowCompositorFrameSink from FrameGenerator

FrameGenerator will live in mus-ws but ServerWindowCompositorFrameSink
will live in mus-gpu. Thus, we should not access it directly.

ServerWindowCompositorFrameSinkManager now serves as a cache of state
from CompositorFrames submitted to mus-gpu. FrameGenerator looks up
that state in ServerWindowCompositorFrameSink.

BUG=658988
==========

to

==========
Mus: Remove dependency on ServerWindowCompositorFrameSink from FrameGenerator

FrameGenerator will live in mus-ws but ServerWindowCompositorFrameSink
will live in mus-gpu. Thus, we should not access it directly.

ServerWindowCompositorFrameSinkManager now serves as a cache of state
from CompositorFrames submitted to mus-gpu. FrameGenerator looks up
that state in ServerWindowCompositorFrameSink.

BUG=658988

Committed: https://crrev.com/fadcdb0baa1441b4f0ddf1e80e456079b926a357
Cr-Commit-Position: refs/heads/master@{#428182}
==========

[commit-bot: I haz the power, 2016-10-27 23:01:08]

Patchset 5 (id:??) landed as
https://crrev.com/fadcdb0baa1441b4f0ddf1e80e456079b926a357
Cr-Commit-Position: refs/heads/master@{#428182}