Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2453003002: [ios] Adds a VoiceSearchController interface to the provider layer. (Closed)

Created:
4 years, 1 month ago by rohitrao (ping after 24h)
Modified:
4 years, 1 month ago
Reviewers:
sdefresne
CC:
chromium-reviews, mac-reviews_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Adds a VoiceSearchController interface to the provider layer. Also moves the voice search pref constants into the provider layer. BUG=656617 Committed: https://crrev.com/a144a499aedea3fe48969f7bb0c16ae5538ccd09 Cr-Commit-Position: refs/heads/master@{#427841}

Patch Set 1 #

Patch Set 2 : [ios] Adds a VoiceSearchController interface to the provider layer. #

Patch Set 3 : Updates. #

Patch Set 4 : Fix compile. #

Total comments: 2

Patch Set 5 : Rebased. #

Patch Set 6 : Rebased. #

Patch Set 7 : Return scoped_refptr. #

Patch Set 8 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+226 lines, -12 lines) Patch
M ios/chrome/browser/BUILD.gn View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/pref_names.h View 1 2 3 2 chunks +4 lines, -3 lines 0 comments Download
M ios/chrome/browser/pref_names.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M ios/chrome/browser/prefs/BUILD.gn View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/prefs/browser_prefs.mm View 1 2 3 4 5 2 chunks +2 lines, -0 lines 0 comments Download
M ios/chrome/browser/voice/BUILD.gn View 1 2 2 chunks +18 lines, -0 lines 0 comments Download
A ios/chrome/browser/voice/voice_search_prefs_registration.h View 1 2 1 chunk +16 lines, -0 lines 0 comments Download
A ios/chrome/browser/voice/voice_search_prefs_registration.cc View 1 2 3 4 1 chunk +16 lines, -0 lines 0 comments Download
M ios/chrome/browser/voice/voice_search_url_rewriter.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/public/provider/chrome/browser/BUILD.gn View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M ios/public/provider/chrome/browser/chrome_browser_provider.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
A ios/public/provider/chrome/browser/voice/voice_search_controller.h View 1 chunk +60 lines, -0 lines 0 comments Download
A ios/public/provider/chrome/browser/voice/voice_search_controller.mm View 1 chunk +38 lines, -0 lines 0 comments Download
A ios/public/provider/chrome/browser/voice/voice_search_controller_delegate.h View 1 chunk +14 lines, -0 lines 0 comments Download
A ios/public/provider/chrome/browser/voice/voice_search_prefs.h View 1 chunk +15 lines, -0 lines 0 comments Download
A ios/public/provider/chrome/browser/voice/voice_search_prefs.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M ios/public/provider/chrome/browser/voice/voice_search_provider.h View 1 2 3 4 5 6 2 chunks +10 lines, -0 lines 0 comments Download
M ios/public/provider/chrome/browser/voice/voice_search_provider.mm View 1 2 3 4 5 6 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 20 (13 generated)
rohitrao (ping after 24h)
4 years, 1 month ago (2016-10-26 17:10:31 UTC) #4
sdefresne
lgtm https://codereview.chromium.org/2453003002/diff/60001/ios/chrome/browser/voice/voice_search_prefs_registration.cc File ios/chrome/browser/voice/voice_search_prefs_registration.cc (right): https://codereview.chromium.org/2453003002/diff/60001/ios/chrome/browser/voice/voice_search_prefs_registration.cc#newcode13 ios/chrome/browser/voice/voice_search_prefs_registration.cc:13: registry->RegisterStringPref(prefs::kVoiceSearchLocale, "", s/""/std::string()/
4 years, 1 month ago (2016-10-26 17:23:07 UTC) #5
rohitrao (ping after 24h)
https://codereview.chromium.org/2453003002/diff/60001/ios/chrome/browser/voice/voice_search_prefs_registration.cc File ios/chrome/browser/voice/voice_search_prefs_registration.cc (right): https://codereview.chromium.org/2453003002/diff/60001/ios/chrome/browser/voice/voice_search_prefs_registration.cc#newcode13 ios/chrome/browser/voice/voice_search_prefs_registration.cc:13: registry->RegisterStringPref(prefs::kVoiceSearchLocale, "", On 2016/10/26 17:23:07, sdefresne wrote: > s/""/std::string()/ ...
4 years, 1 month ago (2016-10-26 18:19:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2453003002/100001
4 years, 1 month ago (2016-10-26 18:20:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2453003002/140001
4 years, 1 month ago (2016-10-26 20:04:23 UTC) #17
commit-bot: I haz the power
Committed patchset #8 (id:140001)
4 years, 1 month ago (2016-10-26 22:08:05 UTC) #18
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 22:11:14 UTC) #20
Message was sent while issue was closed. 
Patchset 8 (id:??) landed as
https://crrev.com/a144a499aedea3fe48969f7bb0c16ae5538ccd09
Cr-Commit-Position: refs/heads/master@{#427841}

Powered by Google App Engine
This is Rietveld 408576698