Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Issue 2452983003: Relax RelatedHistogramBreakdown restrictions. (Closed)

Created:
4 years, 1 month ago by benjhayden
Modified:
4 years, 1 month ago
Reviewers:
nednguyen, hjd
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Relax RelatedHistogramBreakdown restrictions. Currently, RelatedHistogramBreakdown keys must be suffixes of the referenced Histogram names. This would be annoying for memoryMetric, so this CL relaxes that constraint. In order to prevent the usability issue of clicking on a link that says X only to find that a histogram named Y is selected, this a title tooltip is shown when hovering on the legend key containing the full name of the referenced Histogram. BUG=catapult:#2933 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/b1fcad56cd3362b942982ff8db6debb117d5005e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -5 lines) Patch
M tracing/tracing/ui/base/chart_base.html View 4 chunks +14 lines, -0 lines 0 comments Download
M tracing/tracing/ui/base/column_chart_test.html View 1 chunk +1 line, -0 lines 0 comments Download
M tracing/tracing/value/diagnostics/related_histogram_breakdown.html View 1 chunk +0 lines, -5 lines 0 comments Download
M tracing/tracing/value/ui/breakdown_span.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
benjhayden
PTAL :-)
4 years, 1 month ago (2016-10-26 21:55:16 UTC) #2
nednguyen
lgtm
4 years, 1 month ago (2016-10-26 22:00:25 UTC) #3
hjd
lgtm thanks! :)
4 years, 1 month ago (2016-10-26 22:04:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2452983003/1
4 years, 1 month ago (2016-10-26 22:07:15 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 23:09:38 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698