Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(802)

Issue 2452973003: [ios] Do not trigger context menu while scrolling. (Closed)

Created:
4 years, 1 month ago by Eugene But (OOO till 7-30)
Modified:
4 years, 1 month ago
Reviewers:
kkhorimoto
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Do not trigger context menu while scrolling. Fail _contextMenuRecognizer if webview's scroll view panGestureRecognizer was recognized. BUG=642375 Committed: https://crrev.com/033350786362e99d206a97e0e656c2e0a478e3c9 Cr-Commit-Position: refs/heads/master@{#427888}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ios/web/web_state/ui/crw_web_controller.mm View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Eugene But (OOO till 7-30)
4 years, 1 month ago (2016-10-26 21:42:42 UTC) #3
kkhorimoto
lgtm
4 years, 1 month ago (2016-10-27 00:13:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2452973003/1
4 years, 1 month ago (2016-10-27 00:14:25 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-27 00:19:17 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/033350786362e99d206a97e0e656c2e0a478e3c9 Cr-Commit-Position: refs/heads/master@{#427888}
4 years, 1 month ago (2016-10-27 00:21:01 UTC) #12
bzanotti
4 years, 1 month ago (2016-10-27 08:46:49 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2453903003/ by bzanotti@chromium.org.

The reason for reverting is: Breaking many integration tests on iOS downstream..

Powered by Google App Engine
This is Rietveld 408576698