Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 2452943004: MD Settings: Make Passwords URLs match old Options. (Closed)

Created:
4 years, 1 month ago by tommycli
Modified:
4 years, 1 month ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Make Passwords URLs match old Options. Path for the section is now /passwordsAndForms (matching the section title). Path for the manage passwords section is now /passwords (matching the Old Options path. BUG=623587 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/e1cfc89e32131db52e35f0943300fcdd98c5a7c0 Cr-Commit-Position: refs/heads/master@{#427802}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/route.js View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/settings_menu/settings_menu.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (14 generated)
tommycli
dbeam: PTAL, thanks!
4 years, 1 month ago (2016-10-26 18:18:42 UTC) #11
Dan Beam
lgtm
4 years, 1 month ago (2016-10-26 19:32:42 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2452943004/20001
4 years, 1 month ago (2016-10-26 19:53:55 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-26 21:23:56 UTC) #17
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 21:25:53 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e1cfc89e32131db52e35f0943300fcdd98c5a7c0
Cr-Commit-Position: refs/heads/master@{#427802}

Powered by Google App Engine
This is Rietveld 408576698