extensions/browser/app_window/BUILD.gn - Issue 2452943003: Fix a bunch of generated file build flakes in //extensions

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: extensions/browser/app_window/BUILD.gn

Issue 2452943003: Fix a bunch of generated file build flakes in //extensions (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright 2016 The Chromium Authors. All rights reserved.	1 # Copyright 2016 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 source_set("app_window") {	5 source_set("app_window") {

6 sources = [	6 sources = [

7 "app_delegate.h",	7 "app_delegate.h",

8 "app_web_contents_helper.cc",	8 "app_web_contents_helper.cc",

9 "app_web_contents_helper.h",	9 "app_web_contents_helper.h",

10 "app_window.cc",	10 "app_window.cc",

(...skipping 11 matching lines...) Expand all Loading...
22 "size_constraints.h",	22 "size_constraints.h",

23 ]	23 ]

24	24

25 configs += [	25 configs += [

26 # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.	26 # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.

27 "//build/config/compiler:no_size_t_to_int_warning",	27 "//build/config/compiler:no_size_t_to_int_warning",

28 ]	28 ]

29	29

30 deps = [	30 deps = [

31 "//content/public/common",	31 "//content/public/common",

	32 "//extensions:extensions_resources",
	Devlin 2016/10/26 19:30:28 could this just be extensions_browser_resources? could this just be extensions_browser_resources? tsniatowski 2016/10/26 20:43:41 Checked -- yes. I can change this if you prefer. Show quoted text On 2016/10/26 19:30:28, Devlin wrote: > could this just be extensions_browser_resources? Checked -- yes. I can change this if you prefer. Devlin 2016/10/26 21:57:52 Please. extensions_resources includes renderer re Show quoted text On 2016/10/26 20:43:41, tsniatowski wrote: > On 2016/10/26 19:30:28, Devlin wrote: > > could this just be extensions_browser_resources? > > Checked -- yes. I can change this if you prefer. Please. extensions_resources includes renderer resources, which conceptually should not be required in the browser.
32 "//extensions/strings",	33 "//extensions/strings",

33 ]	34 ]

34 }	35 }

OLD	NEW