[regexp] Use SameValue in @@search as specced

src/builtins/builtins-regexp.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/builtins/builtins-utils.h"
 #include "src/builtins/builtins.h"
 
 #include "src/code-factory.h"
 #include "src/regexp/jsregexp.h"
 #include "src/regexp/regexp-utils.h"
@@ skipping 1140 matching lines @@
   Handle<Object> string_obj = args.atOrUndefined(isolate, 1);
 
   Handle<String> string;
   ASSIGN_RETURN_FAILURE_ON_EXCEPTION(isolate, string,
                                      Object::ToString(isolate, string_obj));
 
   Handle<Object> previous_last_index_obj;
   ASSIGN_RETURN_FAILURE_ON_EXCEPTION(isolate, previous_last_index_obj,
                                      RegExpUtils::GetLastIndex(isolate, recv));
 
-  if (!previous_last_index_obj->IsSmi() ||
-      Smi::cast(*previous_last_index_obj)->value() != 0) {
+  if (!previous_last_index_obj->SameValue(Smi::kZero)) {
     RETURN_FAILURE_ON_EXCEPTION(isolate,
                                 RegExpUtils::SetLastIndex(isolate, recv, 0));
   }
 
   Handle<Object> result;
   ASSIGN_RETURN_FAILURE_ON_EXCEPTION(
       isolate, result,
       RegExpUtils::RegExpExec(isolate, recv, string,
                               isolate->factory()->undefined_value()));
 
   Handle<Object> current_last_index_obj;
   ASSIGN_RETURN_FAILURE_ON_EXCEPTION(isolate, current_last_index_obj,
                                      RegExpUtils::GetLastIndex(isolate, recv));
 
-  Maybe<bool> is_last_index_unchanged =
-      Object::Equals(current_last_index_obj, previous_last_index_obj);
-  if (is_last_index_unchanged.IsNothing()) return isolate->pending_exception();
-  if (!is_last_index_unchanged.FromJust()) {
+  const bool is_last_index_unchanged =
+      current_last_index_obj->SameValue(*previous_last_index_obj);
+  if (!is_last_index_unchanged) {
     if (previous_last_index_obj->IsSmi()) {
       RETURN_FAILURE_ON_EXCEPTION(
           isolate,
           RegExpUtils::SetLastIndex(
               isolate, recv, Smi::cast(*previous_last_index_obj)->value()));
     } else {
       RETURN_FAILURE_ON_EXCEPTION(
           isolate,
           Object::SetProperty(recv, isolate->factory()->lastIndex_string(),
                               previous_last_index_obj, STRICT));
@@ skipping 819 matching lines @@
   a->Bind(&if_matched);
   {
     Node* result = ConstructNewResultFromMatchInfo(isolate, a, context,
                                                    match_indices, string);
     a->Return(result);
   }
 }
 
 }  // namespace internal
 }  // namespace v8