[regexp] Use SameValue in @@search as specced

[regexp] Use SameValue in @@search as specced

BUG=v8:5339
Committed: https://crrev.com/534222d1176a47a989a1acffeb4fa2bbaa4f3798
Cr-Commit-Position: refs/heads/master@{#40634}

[jgruber, 2016-10-26 07:55:10]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 07:55:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2016-10-26 07:56:02]

jgruber@chromium.org changed reviewers:
+ yangguo@chromium.org

[jgruber, 2016-10-26 07:56:03]

This addresses your comments in https://codereview.chromium.org/2438683005/
while the TF port hasn't landed yet.

[commit-bot: I haz the power, 2016-10-26 08:26:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 08:26:43]

Dry run: This issue passed the CQ dry run.

[Yang, 2016-10-28 06:47:05]

On 2016/10/26 07:56:03, jgruber wrote:
> This addresses your comments in https://codereview.chromium.org/2438683005/
> while the TF port hasn't landed yet.

lgtm.

[jgruber, 2016-10-28 06:49:59]

The CQ bit was checked by jgruber@chromium.org

[commit-bot: I haz the power, 2016-10-28 06:50:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 07:14:33]

Committed patchset #1 (id:1)

[Dan Ehrenberg, 2016-11-02 12:03:45]

littledan@chromium.org changed reviewers:
+ littledan@chromium.org

[Dan Ehrenberg, 2016-11-02 12:03:45]

https://codereview.chromium.org/2452923002/diff/1/test/mjsunit/regexp.js
File test/mjsunit/regexp.js (right):

https://codereview.chromium.org/2452923002/diff/1/test/mjsunit/regexp.js#newc...
test/mjsunit/regexp.js:749: () => "abc".search(re);
Does this test actually run anything? Did you mean to have an assertThrows call
here?

[jgruber, 2016-11-07 07:56:18]

https://codereview.chromium.org/2452923002/diff/1/test/mjsunit/regexp.js
File test/mjsunit/regexp.js (right):

https://codereview.chromium.org/2452923002/diff/1/test/mjsunit/regexp.js#newc...
test/mjsunit/regexp.js:749: () => "abc".search(re);
On 2016/11/02 12:03:45, Dan Ehrenberg wrote:
> Does this test actually run anything? Did you mean to have an assertThrows
call
> here?

Good catch, thanks! This line was originally in an assertThrows, which tested a
specific code path in Object::Equals when lastIndex was not convertible to
primitive. 

However, assertThrows is no longer correct now that we use Object::SameValue
instead, which does not throw in this case.

Will fix in another CL.

[commit-bot: I haz the power, 2016-11-17 22:16:13]

Description was changed from

==========
[regexp] Use SameValue in @@search as specced

BUG=v8:5339
==========

to

==========
[regexp] Use SameValue in @@search as specced

BUG=v8:5339

Committed: https://crrev.com/534222d1176a47a989a1acffeb4fa2bbaa4f3798
Cr-Commit-Position: refs/heads/master@{#40634}
==========

[commit-bot: I haz the power, 2016-11-17 22:16:14]

Patchset 1 (id:??) landed as
https://crrev.com/534222d1176a47a989a1acffeb4fa2bbaa4f3798
Cr-Commit-Position: refs/heads/master@{#40634}