[regexp] Set static property attributes as in spec proposal

src/bootstrapper.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/bootstrapper.h"
 
 #include "src/accessors.h"
 #include "src/api-natives.h"
 #include "src/base/ieee754.h"
 #include "src/code-stubs.h"
@@ skipping 1856 matching lines @@
       }
 
       // Store the initial RegExp.prototype map. This is used in fast-path
       // checks. Do not alter the prototype after this point.
       native_context()->set_regexp_prototype_map(prototype->map());
     }
 
     {
       // RegExp getters and setters.
 
-      // TODO(jgruber): This should really be DONT_ENUM | DONT_DELETE.
-      // However, that currently breaks layout test expectations. Note that
-      // Firefox sets a couple of these as enumerable.
-      // On the other hand, installing attributes as DONT_ENUM matches the draft
-      // specification at
-      // https://github.com/claudepache/es-regexp-legacy-static-properties.
-      const PropertyAttributes no_enum = DONT_ENUM;
-
       SimpleInstallGetter(regexp_fun,
                           factory->InternalizeUtf8String("[Symbol.species]"),
                           factory->species_symbol(),
                           Builtins::kRegExpPrototypeSpeciesGetter, false);
 
       // Static properties set by a successful match.
 
+      const PropertyAttributes no_enum = DONT_ENUM;
       SimpleInstallGetterSetter(regexp_fun, factory->input_string(),
                                 Builtins::kRegExpInputGetter,
-                                Builtins::kRegExpInputSetter, DONT_DELETE);
+                                Builtins::kRegExpInputSetter, no_enum);
       SimpleInstallGetterSetter(
           regexp_fun, factory->InternalizeUtf8String("$_"),
           Builtins::kRegExpInputGetter, Builtins::kRegExpInputSetter, no_enum);
 
       SimpleInstallGetterSetter(
           regexp_fun, factory->InternalizeUtf8String("lastMatch"),
           Builtins::kRegExpLastMatchGetter, Builtins::kEmptyFunction, no_enum);
       SimpleInstallGetterSetter(
           regexp_fun, factory->InternalizeUtf8String("$&"),
           Builtins::kRegExpLastMatchGetter, Builtins::kEmptyFunction, no_enum);
@@ skipping 16 matching lines @@
 
       SimpleInstallGetterSetter(regexp_fun,
                                 factory->InternalizeUtf8String("rightContext"),
                                 Builtins::kRegExpRightContextGetter,
                                 Builtins::kEmptyFunction, no_enum);
       SimpleInstallGetterSetter(regexp_fun,
                                 factory->InternalizeUtf8String("$'"),
                                 Builtins::kRegExpRightContextGetter,
                                 Builtins::kEmptyFunction, no_enum);
 
-#define INSTALL_CAPTURE_GETTER(i)                                   \
-  SimpleInstallGetterSetter(regexp_fun,                             \
-                            factory->InternalizeUtf8String("$" #i), \
-                            Builtins::kRegExpCapture##i##Getter,    \
-                            Builtins::kEmptyFunction, DONT_DELETE)
+#define INSTALL_CAPTURE_GETTER(i)                         \
+  SimpleInstallGetterSetter(                              \
+      regexp_fun, factory->InternalizeUtf8String("$" #i), \
+      Builtins::kRegExpCapture##i##Getter, Builtins::kEmptyFunction, no_enum)
       INSTALL_CAPTURE_GETTER(1);
       INSTALL_CAPTURE_GETTER(2);
       INSTALL_CAPTURE_GETTER(3);
       INSTALL_CAPTURE_GETTER(4);
       INSTALL_CAPTURE_GETTER(5);
       INSTALL_CAPTURE_GETTER(6);
       INSTALL_CAPTURE_GETTER(7);
       INSTALL_CAPTURE_GETTER(8);
       INSTALL_CAPTURE_GETTER(9);
 #undef INSTALL_CAPTURE_GETTER
@@ skipping 2626 matching lines @@
 }
 
 
 // Called when the top-level V8 mutex is destroyed.
 void Bootstrapper::FreeThreadResources() {
   DCHECK(!IsActive());
 }
 
 }  // namespace internal
 }  // namespace v8