Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2452903002: INPUT element: Updating value to the previous defaultValue should dispatch "change" event. (Closed)

Created:
4 years, 1 month ago by tkent
Modified:
4 years, 1 month ago
Reviewers:
keishi
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

INPUT element: Updating value to the previous defaultValue should dispatch "change" event. We have set defaultValue to m_textAsOfLastFormControlChangeEvent only when input type was determined, and updating defalutValue after it didn't update m_textAsOfLastFormControlChangeEvent. So, 'change' event was not dispatched in some cases. BUG=659499 Committed: https://crrev.com/3393d5c2830af28ce61500bf66cdae94cddfc028 Cr-Commit-Position: refs/heads/master@{#427675}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/fast/forms/text/text-change-event-after-updating-default.html View 1 chunk +17 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLInputElement.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
tkent
keishi@, would you review this please?
4 years, 1 month ago (2016-10-26 08:29:03 UTC) #4
keishi
LGTM
4 years, 1 month ago (2016-10-26 11:18:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2452903002/1
4 years, 1 month ago (2016-10-26 13:23:57 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-26 13:29:00 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 13:32:33 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3393d5c2830af28ce61500bf66cdae94cddfc028
Cr-Commit-Position: refs/heads/master@{#427675}

Powered by Google App Engine
This is Rietveld 408576698