Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 24529002: Revert OS::TimeCurrentMillis on Windows introduced in r16413. (Closed)

Created:
7 years, 2 months ago by Hannes Payer (out of office)
Modified:
7 years, 2 months ago
Reviewers:
danno, Jakob Kummerow
CC:
v8-dev, Benedikt Meurer
Visibility:
Public.

Description

Revert OS::TimeCurrentMillis on Windows introduced in r16413. BUG=chromium:288924 R=danno@chromium.org, jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16938

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -8 lines) Patch
M src/platform-win32.cc View 1 4 chunks +69 lines, -1 line 0 comments Download
A + test/mjsunit/timer.js View 1 2 3 1 chunk +6 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Hannes Payer (out of office)
7 years, 2 months ago (2013-09-25 08:33:47 UTC) #1
danno
lgtm
7 years, 2 months ago (2013-09-25 08:34:55 UTC) #2
Jakob Kummerow
LGTM. Thanks for the new test case!
7 years, 2 months ago (2013-09-25 09:05:15 UTC) #3
Hannes Payer (out of office)
7 years, 2 months ago (2013-09-25 09:50:58 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 manually as r16938 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698